From 0be4a42701a0b6d69311f775effaaf79b30f5354 Mon Sep 17 00:00:00 2001
From: Itai Caspi <itai.caspi@intel.com>
Date: Sun, 19 Aug 2018 10:39:03 +0300
Subject: [PATCH] updates needed for the pip package

---
 MANIFEST.in | 10 +++++++---
 setup.py    | 13 ++++++++++++-
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/MANIFEST.in b/MANIFEST.in
index b2ed5e5..3ad14bd 100644
--- a/MANIFEST.in
+++ b/MANIFEST.in
@@ -1,3 +1,7 @@
-include *.txt
-include rl_coach/environments/CarlaSettings.ini
-include rl_coach/dashboard_components/spinner.css
+include rl_coach/dashboard_components/*.css
+include rl_coach/environments/doom/*.cfg
+include rl_coach/environments/doom/*.wad
+include rl_coach/environments/mujoco/common/*.xml
+include rl_coach/environments/mujoco/*.xml
+include rl_coach/environments/*.ini
+include rl_coach/tests/*.ini
\ No newline at end of file
diff --git a/setup.py b/setup.py
index 37c20e1..0f15490 100644
--- a/setup.py
+++ b/setup.py
@@ -23,6 +23,11 @@ from setuptools import setup, find_packages
 import subprocess
 
 # Creating the pip package involves the following steps:
+# - Define the pip package related files - setup.py (this file) and MANIFEST.in by:
+# 1. Make sure all the requirements in install_requires are defined correctly and that their version is the correct one
+# 2. Add all the non .py files to the package_data and to the MANIFEST.in file
+# 3. Make sure that all the python directories have an __init__.py file
+
 # - Check that everything works fine by:
 # 1. Create a new virtual environment using `virtualenv coach_env -p python3`
 # 2. Run `pip install -e .`
@@ -70,7 +75,13 @@ setup(
     packages=find_packages(),
     python_requires="==3.5.*",
     install_requires=install_requires,
-    package_data={'rl_coach': ['dashboard_components/*.css', '*.css', 'environments/*.ini']},
+    package_data={'rl_coach': ['dashboard_components/*.css',
+                               'environments/doom/*.cfg',
+                               'environments/doom/*.wad',
+                               'environments/mujoco/common/*.xml',
+                               'environments/mujoco/*.xml',
+                               'environments/*.ini',
+                               'tests/*.ini']},
     entry_points={
         'console_scripts': [
             'coach=rl_coach.coach:main',