From 5fee48dcfdd6b6c1ed1259e29fce23d0b5c8ce26 Mon Sep 17 00:00:00 2001 From: Zach Dwiel Date: Thu, 4 Oct 2018 11:59:05 -0400 Subject: [PATCH] remove argument keep_networks_in_sync from GraphManager.act, and move this feature into the only place that activated it: GraphManager.train_and_act --- rl_coach/graph_managers/graph_manager.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/rl_coach/graph_managers/graph_manager.py b/rl_coach/graph_managers/graph_manager.py index 201c67b..f0788ff 100644 --- a/rl_coach/graph_managers/graph_manager.py +++ b/rl_coach/graph_managers/graph_manager.py @@ -348,11 +348,10 @@ class GraphManager(object): [environment.reset_internal_state(force_environment_reset) for environment in self.environments] [manager.reset_internal_state() for manager in self.level_managers] - def act(self, steps: PlayingStepsType, keep_networks_in_sync=False) -> (int, bool): + def act(self, steps: PlayingStepsType) -> (int, bool): """ Do several steps of acting on the environment :param steps: the number of steps as a tuple of steps time and steps count - :param keep_networks_in_sync: sync the network parameters with the global network before each episode """ self.verify_graph_was_created() @@ -386,8 +385,6 @@ class GraphManager(object): self.handle_episode_ended() self.reset_required = True - if keep_networks_in_sync: - self.sync_graph() def train_and_act(self, steps: StepMethod) -> None: """ @@ -436,7 +433,8 @@ class GraphManager(object): # act for at least `steps`, though don't interrupt an episode count_end = self.total_steps_counters[self.phase][steps.__class__] + steps.num_steps while self.total_steps_counters[self.phase][steps.__class__] < count_end: - self.act(EnvironmentEpisodes(1), keep_networks_in_sync=keep_networks_in_sync) + self.act(EnvironmentEpisodes(1)) + self.sync_graph() def restore_checkpoint(self): self.verify_graph_was_created()