From 787ab42578a0687fe20f0401c15dd32c283b44b7 Mon Sep 17 00:00:00 2001 From: zach dwiel Date: Wed, 10 Oct 2018 16:20:59 -0400 Subject: [PATCH] remove extra call to super().store_episode --- .../memories/episodic/episodic_hindsight_experience_replay.py | 4 ---- rl_coach/tests/memories/test_hindsight_experience_replay.py | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/rl_coach/memories/episodic/episodic_hindsight_experience_replay.py b/rl_coach/memories/episodic/episodic_hindsight_experience_replay.py index ad006f1..c30f451 100644 --- a/rl_coach/memories/episodic/episodic_hindsight_experience_replay.py +++ b/rl_coach/memories/episodic/episodic_hindsight_experience_replay.py @@ -106,10 +106,6 @@ class EpisodicHindsightExperienceReplay(EpisodicExperienceReplay): ] def store_episode(self, episode: Episode, lock: bool=True) -> None: - - # Calling super.store() so that in case a memory backend is used, the memory backend can store this episode. - super().store_episode(episode) - # generate hindsight transitions only when an episode is finished last_episode_transitions = copy.copy(episode.transitions) diff --git a/rl_coach/tests/memories/test_hindsight_experience_replay.py b/rl_coach/tests/memories/test_hindsight_experience_replay.py index 9efbd45..02ef821 100644 --- a/rl_coach/tests/memories/test_hindsight_experience_replay.py +++ b/rl_coach/tests/memories/test_hindsight_experience_replay.py @@ -94,4 +94,4 @@ def test_update_episode(her): else: assert not transition.game_over -test_update_episode(her()) \ No newline at end of file +# test_update_episode(her())