gryf/coach
1
0
Fork 0
mirror of https://github.com/gryf/coach.git synced 2025-12-18 11:40:18 +01:00
Code Issues Projects Releases Wiki Activity

Fix golden tests (#199)

Browse Source 
* remove unused functions utils.read_json and utils.write_json
* increase verbosity of golden tests; detect errors in golden tests
This commit is contained in:
Zach Dwiel
2019-01-16 20:38:11 -05:00
committed by Scott Leishman
parent fedb4cbd7c
commit 8672f8b542
2 changed files with 6 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
rl_coach/tests/test_golden.py
View File

@@ -100,7 +100,7 @@ def preset_name(request):
@pytest.mark.golden_test
def test_preset_reward(preset_name, no_progress_bar=False, time_limit=60 * 60, verbose=False):
def test_preset_reward(preset_name, no_progress_bar=True, time_limit=60 * 60, verbose=True):
preset_validation_params = validation_params(preset_name)
win_size = 10
@@ -221,7 +221,8 @@ def test_preset_reward(preset_name, no_progress_bar=False, time_limit=60 * 60, v
shutil.rmtree(test_path)
os.remove(log_file_name)
return test_passed
if not test_passed:
raise ValueError('golden test failed')
def main():
@@ -278,8 +279,9 @@ def main():
continue
test_count += 1
test_passed = test_preset_reward(preset_name, args.no_progress_bar, args.time_limit, args.verbose)
if not test_passed:
try:
test_preset_reward(preset_name, args.no_progress_bar, args.time_limit, args.verbose)
except Exception as e:
fail_count += 1
screen.separator()