gryf/coach
1
0
Fork 0
mirror of https://github.com/gryf/coach.git synced 2025-12-17 19:20:19 +01:00
Code Issues Projects Releases Wiki Activity

Do not hardcode path to bash (#332)

Browse Source
This commit is contained in:
Timo Kaufmann
2019-06-10 19:10:28 +02:00
committed by Gal Novik
parent a1bb8eef89
commit 8df3c46756
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rl_coach/coach.py
View File

@@ -66,8 +66,8 @@ def open_dashboard(experiment_path):
dashboard_path = 'python {}/dashboard.py'.format(get_base_dir()) dashboard_path = 'python {}/dashboard.py'.format(get_base_dir())
cmd = "{} --experiment_dir {}".format(dashboard_path, experiment_path) cmd = "{} --experiment_dir {}".format(dashboard_path, experiment_path)
screen.log_title("Opening dashboard - experiment path: {}".format(experiment_path)) screen.log_title("Opening dashboard - experiment path: {}".format(experiment_path))
# subprocess.Popen(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True, executable="/bin/bash") # subprocess.Popen(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, shell=True, executable="bash")
subprocess.Popen(cmd, shell=True, executable="/bin/bash") subprocess.Popen(cmd, shell=True, executable="bash")
def start_graph(graph_manager: 'GraphManager', task_parameters: 'TaskParameters'): def start_graph(graph_manager: 'GraphManager', task_parameters: 'TaskParameters'):

2
rl_coach/tests/test_eks.py
View File

@@ -42,7 +42,7 @@ class EKSHandler():
container = client.V1Container( container = client.V1Container(
name=self.test_name, name=self.test_name,
image=self.image, image=self.image,
command=['/bin/bash', '-c'], command=['bash', '-c'],
args=[self.test_command], args=[self.test_command],
image_pull_policy='Always', image_pull_policy='Always',
working_dir=self.working_dir, working_dir=self.working_dir,

2
rl_coach/utils.py
View File

@@ -139,7 +139,7 @@ def ClassToDict(x):
def cmd_line_run(result, run_cmd, id=-1): def cmd_line_run(result, run_cmd, id=-1):
p = Popen(run_cmd, shell=True, executable="/bin/bash") p = Popen(run_cmd, shell=True, executable="bash")
while result[0] is None or result[0] == [None]: while result[0] is None or result[0] == [None]:
if id in killed_processes: if id in killed_processes:
p.kill() p.kill()