From cccfe88f9b390ffdefc0826a95f273ba46a8c00f Mon Sep 17 00:00:00 2001 From: Zach Dwiel Date: Fri, 7 Sep 2018 14:50:50 -0400 Subject: [PATCH] remove unused method: update_last_transition_info --- .../episodic/episodic_experience_replay.py | 17 ----------------- .../memories/non_episodic/experience_replay.py | 14 -------------- 2 files changed, 31 deletions(-) diff --git a/rl_coach/memories/episodic/episodic_experience_replay.py b/rl_coach/memories/episodic/episodic_experience_replay.py index 2c86c5f..79f9aaf 100644 --- a/rl_coach/memories/episodic/episodic_experience_replay.py +++ b/rl_coach/memories/episodic/episodic_experience_replay.py @@ -273,23 +273,6 @@ class EpisodicExperienceReplay(Memory): """ self.remove_episode(episode_index) - def update_last_transition_info(self, info: Dict[str, Any]) -> None: - """ - Update the info of the last transition stored in the memory - :param info: the new info to append to the existing info - :return: None - """ - self.reader_writer_lock.lock_writing_and_reading() - - episode = self._buffer[-1] - if episode.length() == 0: - if len(self._buffer) < 2: - return - episode = self._buffer[-2] - episode.transitions[-1].info.update(info) - - self.reader_writer_lock.release_writing_and_reading() - def clean(self) -> None: """ Clean the memory by removing all the episodes diff --git a/rl_coach/memories/non_episodic/experience_replay.py b/rl_coach/memories/non_episodic/experience_replay.py index a73e44a..798854c 100644 --- a/rl_coach/memories/non_episodic/experience_replay.py +++ b/rl_coach/memories/non_episodic/experience_replay.py @@ -182,20 +182,6 @@ class ExperienceReplay(Memory): """ self.remove_transition(transition_index, lock) - def update_last_transition_info(self, info: Dict[str, Any]) -> None: - """ - Update the info of the last transition stored in the memory - :param info: the new info to append to the existing info - :return: None - """ - self.reader_writer_lock.lock_writing_and_reading() - - if self.length() == 0: - raise ValueError("There are no transition in the replay buffer") - self.transitions[-1].info.update(info) - - self.reader_writer_lock.release_writing_and_reading() - def clean(self, lock: bool=True) -> None: """ Clean the memory by removing all the episodes