1
0
mirror of https://github.com/gryf/fs-uae-wrapper.git synced 2025-12-26 08:22:44 +01:00

Parametrize extract and create methods for Archive base class

This commit is contained in:
2017-01-02 20:17:13 +01:00
parent 19acb789b6
commit 994768806c
5 changed files with 46 additions and 31 deletions

View File

@@ -143,14 +143,14 @@ class TestBase(TestCase):
run.assert_called_once_with(['fs-uae'])
@mock.patch('fs_uae_wrapper.base.Base._get_saves_dir')
@mock.patch('fs_uae_wrapper.utils.run_command')
def test_save_save(self, run, saves_dir):
@mock.patch('fs_uae_wrapper.utils.create_archive')
def test_save_save(self, carch, saves_dir):
bobj = base.Base('Config.fs-uae', utils.CmdOption(), {})
bobj.dir = self.dirname
bobj.save_filename = 'foobar_save.7z'
saves_dir.bobj.save_filenamereturn_value = None
run.return_value = True
carch.return_value = True
self.assertTrue(bobj._save_save())
@@ -164,16 +164,16 @@ class TestBase(TestCase):
os.mkdir(os.path.join(self.dirname, 'fs-uae-save'))
self.assertTrue(bobj._save_save())
run.return_value = False
carch.return_value = False
self.assertFalse(bobj._save_save())
@mock.patch('fs_uae_wrapper.utils.run_command')
def test_load_save(self, run):
@mock.patch('fs_uae_wrapper.utils.extract_archive')
def test_load_save(self, earch):
bobj = base.Base('Config.fs-uae', utils.CmdOption(), {})
bobj.dir = self.dirname
bobj.save_filename = "foobar_save.7z"
run.return_value = 0
earch.return_value = 0
# fail to load save is not fatal
self.assertTrue(bobj._load_save())
@@ -183,11 +183,11 @@ class TestBase(TestCase):
fobj.write('asd')
self.assertTrue(bobj._load_save())
run.assert_called_once_with(['7z', 'x', bobj.save_filename])
earch.assert_called_once_with(bobj.save_filename)
# failure in searching for archiver are also non fatal
run.reset_mock()
run.return_value = 1
earch.reset_mock()
earch.return_value = 1
self.assertTrue(bobj._save_save())
def test_get_saves_dir(self):

View File

@@ -83,13 +83,14 @@ class TestUtils(TestCase):
which.return_value = None
# No config
self.assertFalse(utils.operate_archive('non-existend.7z', 'foo', ''))
self.assertFalse(utils.operate_archive('non-existend.7z', 'foo', '',
None))
# Archive type not known
with open('unsupported-archive.ace', 'w') as fobj:
fobj.write("\n")
self.assertFalse(utils.operate_archive('unsupported-archive.ace',
'foo', ''))
'foo', '', None))
# archive is known, but extraction will fail - we have an empty
# archive and there is no guarantee, that 7z exists on system where
@@ -99,17 +100,17 @@ class TestUtils(TestCase):
with open('supported-archive.7z', 'w') as fobj:
fobj.write("\n")
self.assertTrue(utils.operate_archive('supported-archive.7z',
'extract', ''))
'extract', '', None))
extract.assert_called_once()
extract.reset_mock()
self.assertTrue(utils.operate_archive('supported-archive.7z',
'extract', ''))
'extract', '', None))
extract.assert_called_once()
os.unlink('supported-archive.7z')
self.assertTrue(utils.operate_archive('supported-archive.7z',
'create', 'test'))
'create', 'test', ['foo']))
create.assert_called_once()
show.assert_called_once()