From 53fe3874337d8a8a7e74cb98a6a7748a72de6aa3 Mon Sep 17 00:00:00 2001 From: gryf Date: Fri, 19 Aug 2022 21:02:55 +0200 Subject: [PATCH] Patch for distinguish shift-insert/ctrl-v in GTK. Developers for desktop env like Gnome have wrong impression, that one clipboard is enough for everybody. There might be true for environments like MacOS or Windows, but not under X11, where there are three clipboards, where two of them are accessible using two different keyboard shortcuts. And they "unified" all of the shortcuts, to the common lowest denominator and make shoft-insert and ctrl-v behave exactly the same: paste from the clipboard instead of primary selection, which I found at least stupid, to be polite. Note, that this patch will work for most apps using GTK2/GTK3 toolkits, while there might be other software, which follows this nonsense like Firefox, so even if it uses GTK underneath, it still breaks the shortcut key. --- .../gtk+:2/gtk+-2.24.32_shift_insert.patch | 186 ++++++++++++++++ x11-libs/gtk+:3/gtk+-3.24.1_insert.patch | 206 ++++++++++++++++++ 2 files changed, 392 insertions(+) create mode 100644 x11-libs/gtk+:2/gtk+-2.24.32_shift_insert.patch create mode 100644 x11-libs/gtk+:3/gtk+-3.24.1_insert.patch diff --git a/x11-libs/gtk+:2/gtk+-2.24.32_shift_insert.patch b/x11-libs/gtk+:2/gtk+-2.24.32_shift_insert.patch new file mode 100644 index 0000000..d4a9588 --- /dev/null +++ b/x11-libs/gtk+:2/gtk+-2.24.32_shift_insert.patch @@ -0,0 +1,186 @@ +diff -ur gtk+-2.24.32/gtk/gtkentry.c gtk+-2.24.32_patched/gtk/gtkentry.c +--- gtk+-2.24.32/gtk/gtkentry.c 2017-12-10 03:41:59.000000000 +0100 ++++ gtk+-2.24.32_patched/gtk/gtkentry.c 2019-03-24 08:29:44.716256488 +0100 +@@ -168,6 +168,7 @@ + CUT_CLIPBOARD, + COPY_CLIPBOARD, + PASTE_CLIPBOARD, ++ PASTE_SELECTION, + TOGGLE_OVERWRITE, + ICON_PRESS, + ICON_RELEASE, +@@ -382,6 +383,8 @@ + static void gtk_entry_cut_clipboard (GtkEntry *entry); + static void gtk_entry_copy_clipboard (GtkEntry *entry); + static void gtk_entry_paste_clipboard (GtkEntry *entry); ++static void gtk_entry_paste_selection (GtkEntry *entry, ++ const gchar *which); + static void gtk_entry_toggle_overwrite (GtkEntry *entry); + static void gtk_entry_select_all (GtkEntry *entry); + static void gtk_entry_real_activate (GtkEntry *entry); +@@ -612,6 +615,7 @@ + class->cut_clipboard = gtk_entry_cut_clipboard; + class->copy_clipboard = gtk_entry_copy_clipboard; + class->paste_clipboard = gtk_entry_paste_clipboard; ++ class->paste_selection = gtk_entry_paste_selection; + class->toggle_overwrite = gtk_entry_toggle_overwrite; + class->activate = gtk_entry_real_activate; + class->get_text_area_size = gtk_entry_get_text_area_size; +@@ -1485,6 +1489,17 @@ + _gtk_marshal_VOID__VOID, + G_TYPE_NONE, 0); + ++ signals[PASTE_SELECTION] = ++ g_signal_new (I_("paste-selection"), ++ G_OBJECT_CLASS_TYPE (gobject_class), ++ G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, ++ G_STRUCT_OFFSET (GtkEntryClass, paste_selection), ++ NULL, NULL, ++ _gtk_marshal_VOID__STRING, ++ G_TYPE_NONE, 1, ++ G_TYPE_STRING); ++ ++ + /** + * GtkEntry::toggle-overwrite: + * @entry: the object which received the signal +@@ -5118,6 +5133,26 @@ + } + + static void ++gtk_entry_paste_selection (GtkEntry *entry, ++ const gchar *which) ++{ ++ if (entry->editable) ++ { ++ if (g_str_equal(which, "primary")) ++ gtk_entry_paste (entry, GDK_SELECTION_PRIMARY); ++ else if (g_str_equal(which, "secondary")) ++ gtk_entry_paste (entry, GDK_SELECTION_PRIMARY); ++ else if (g_str_equal(which, "clipboard")) ++ gtk_entry_paste (entry, GDK_SELECTION_CLIPBOARD); ++ else ++ gtk_widget_error_bell (GTK_WIDGET (entry)); ++ } ++ else ++ gtk_widget_error_bell (GTK_WIDGET (entry)); ++} ++ ++ ++static void + gtk_entry_delete_cb (GtkEntry *entry) + { + GtkEditable *editable = GTK_EDITABLE (entry); +diff -ur gtk+-2.24.32/gtk/gtkentry.h gtk+-2.24.32_patched/gtk/gtkentry.h +--- gtk+-2.24.32/gtk/gtkentry.h 2016-10-22 06:11:44.000000000 +0200 ++++ gtk+-2.24.32_patched/gtk/gtkentry.h 2019-03-24 08:35:02.484264490 +0100 +@@ -158,9 +158,11 @@ + gint *width, + gint *height); + ++ void (* paste_selection) (GtkEntry *entry, ++ const gchar *which); ++ + /* Padding for future expansion */ + void (*_gtk_reserved1) (void); +- void (*_gtk_reserved2) (void); + }; + + GType gtk_entry_get_type (void) G_GNUC_CONST; +diff -ur gtk+-2.24.32/gtk/gtktextview.c gtk+-2.24.32_patched/gtk/gtktextview.c +--- gtk+-2.24.32/gtk/gtktextview.c 2017-04-08 07:34:42.000000000 +0200 ++++ gtk+-2.24.32_patched/gtk/gtktextview.c 2019-03-24 08:58:36.752300106 +0100 +@@ -135,6 +135,7 @@ + CUT_CLIPBOARD, + COPY_CLIPBOARD, + PASTE_CLIPBOARD, ++ PASTE_SELECTION, + TOGGLE_OVERWRITE, + MOVE_VIEWPORT, + SELECT_ALL, +@@ -281,6 +282,8 @@ + static void gtk_text_view_cut_clipboard (GtkTextView *text_view); + static void gtk_text_view_copy_clipboard (GtkTextView *text_view); + static void gtk_text_view_paste_clipboard (GtkTextView *text_view); ++static void gtk_text_view_paste_selection (GtkTextView *text_view, ++ const gchar *which); + static void gtk_text_view_toggle_overwrite (GtkTextView *text_view); + static void gtk_text_view_toggle_cursor_visible (GtkTextView *text_view); + static void gtk_text_view_compat_move_focus(GtkTextView *text_view, +@@ -532,6 +535,7 @@ + klass->cut_clipboard = gtk_text_view_cut_clipboard; + klass->copy_clipboard = gtk_text_view_copy_clipboard; + klass->paste_clipboard = gtk_text_view_paste_clipboard; ++ klass->paste_selection = gtk_text_view_paste_selection; + klass->toggle_overwrite = gtk_text_view_toggle_overwrite; + klass->move_focus = gtk_text_view_compat_move_focus; + klass->set_scroll_adjustments = gtk_text_view_set_scroll_adjustments; +@@ -946,6 +950,16 @@ + _gtk_marshal_VOID__VOID, + G_TYPE_NONE, 0); + ++ signals[PASTE_SELECTION] = ++ g_signal_new (I_("paste-selection"), ++ G_OBJECT_CLASS_TYPE (gobject_class), ++ G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, ++ G_STRUCT_OFFSET (GtkTextViewClass, paste_selection), ++ NULL, NULL, ++ _gtk_marshal_VOID__STRING, ++ G_TYPE_NONE, 1, ++ G_TYPE_STRING); ++ + /** + * GtkTextView::toggle-overwrite: + * @text_view: the object which received the signal +@@ -5843,6 +5857,31 @@ + } + + static void ++gtk_text_view_paste_selection (GtkTextView *text_view, ++ const gchar *which) ++{ ++ GtkClipboard *clipboard = NULL; ++ ++ if (g_str_equal (which, "primary")) ++ clipboard = gtk_widget_get_clipboard (GTK_WIDGET (text_view), ++ GDK_SELECTION_PRIMARY); ++ else if (g_str_equal (which, "secondary")) ++ clipboard = gtk_widget_get_clipboard (GTK_WIDGET (text_view), ++ GDK_SELECTION_SECONDARY); ++ else if (g_str_equal (which, "clipboard")) ++ clipboard = gtk_widget_get_clipboard (GTK_WIDGET (text_view), ++ GDK_SELECTION_CLIPBOARD); ++ ++ if (clipboard) ++ gtk_text_buffer_paste_clipboard (get_buffer (text_view), ++ clipboard, ++ NULL, ++ text_view->editable); ++ else ++ gtk_widget_error_bell (GTK_WIDGET (text_view)); ++} ++ ++static void + gtk_text_view_paste_done_handler (GtkTextBuffer *buffer, + GtkClipboard *clipboard, + gpointer data) +diff -ur gtk+-2.24.32/gtk/gtktextview.h gtk+-2.24.32_patched/gtk/gtktextview.h +--- gtk+-2.24.32/gtk/gtktextview.h 2016-10-22 06:11:45.000000000 +0200 ++++ gtk+-2.24.32_patched/gtk/gtktextview.h 2019-03-24 08:34:41.716263967 +0100 +@@ -203,6 +203,8 @@ + */ + void (* move_focus) (GtkTextView *text_view, + GtkDirectionType direction); ++ void (* paste_selection) (GtkTextView *text_view, ++ const gchar *which); + + /* Padding for future expansion */ + void (*_gtk_reserved1) (void); +@@ -211,7 +213,6 @@ + void (*_gtk_reserved4) (void); + void (*_gtk_reserved5) (void); + void (*_gtk_reserved6) (void); +- void (*_gtk_reserved7) (void); + }; + + GType gtk_text_view_get_type (void) G_GNUC_CONST; diff --git a/x11-libs/gtk+:3/gtk+-3.24.1_insert.patch b/x11-libs/gtk+:3/gtk+-3.24.1_insert.patch new file mode 100644 index 0000000..de3ba20 --- /dev/null +++ b/x11-libs/gtk+:3/gtk+-3.24.1_insert.patch @@ -0,0 +1,206 @@ +diff -ur gtk+-3.24.1/gtk/gtkentry.c gtk+-3.24.1_patched/gtk/gtkentry.c +--- gtk+-3.24.1/gtk/gtkentry.c 2018-06-03 15:43:28.000000000 +0200 ++++ gtk+-3.24.1_patched/gtk/gtkentry.c 2019-03-24 12:26:55.484614867 +0100 +@@ -323,6 +323,7 @@ + CUT_CLIPBOARD, + COPY_CLIPBOARD, + PASTE_CLIPBOARD, ++ PASTE_SELECTION, + TOGGLE_OVERWRITE, + ICON_PRESS, + ICON_RELEASE, +@@ -552,6 +553,7 @@ + static void gtk_entry_cut_clipboard (GtkEntry *entry); + static void gtk_entry_copy_clipboard (GtkEntry *entry); + static void gtk_entry_paste_clipboard (GtkEntry *entry); ++static void gtk_entry_paste_selection (GtkEntry *entry); + static void gtk_entry_toggle_overwrite (GtkEntry *entry); + static void gtk_entry_insert_emoji (GtkEntry *entry); + static void gtk_entry_select_all (GtkEntry *entry); +@@ -816,6 +818,7 @@ + class->cut_clipboard = gtk_entry_cut_clipboard; + class->copy_clipboard = gtk_entry_copy_clipboard; + class->paste_clipboard = gtk_entry_paste_clipboard; ++ class->paste_selection = gtk_entry_paste_selection; + class->toggle_overwrite = gtk_entry_toggle_overwrite; + class->insert_emoji = gtk_entry_insert_emoji; + class->activate = gtk_entry_real_activate; +@@ -1828,6 +1831,15 @@ + NULL, + G_TYPE_NONE, 0); + ++ signals[PASTE_SELECTION] = ++ g_signal_new (I_("paste-selection"), ++ G_OBJECT_CLASS_TYPE (gobject_class), ++ G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, ++ G_STRUCT_OFFSET (GtkEntryClass, paste_selection), ++ NULL, NULL, ++ NULL, ++ G_TYPE_NONE, 0); ++ + /** + * GtkEntry::toggle-overwrite: + * @entry: the object which received the signal +@@ -2086,14 +2098,14 @@ + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, GDK_CONTROL_MASK, + "copy-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, GDK_SHIFT_MASK, +- "paste-clipboard", 0); ++ "paste-selection", 0); + + gtk_binding_entry_add_signal (binding_set, GDK_KEY_KP_Delete, GDK_SHIFT_MASK, + "cut-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_KP_Insert, GDK_CONTROL_MASK, + "copy-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_KP_Insert, GDK_SHIFT_MASK, +- "paste-clipboard", 0); ++ "paste-selection", 0); + + /* Overwrite */ + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, 0, +@@ -5986,6 +5998,27 @@ + } + } + ++static void ++gtk_entry_paste_selection (GtkEntry *entry) ++{ ++ GtkEntryPrivate *priv = entry->priv; ++ ++ if (priv->editable) ++ gtk_entry_paste (entry, GDK_SELECTION_PRIMARY); ++ else ++ gtk_widget_error_bell (GTK_WIDGET (entry)); ++ ++ if (priv->text_handle) ++ { ++ GtkTextHandleMode handle_mode; ++ ++ handle_mode = _gtk_text_handle_get_mode (priv->text_handle); ++ ++ if (handle_mode != GTK_TEXT_HANDLE_MODE_NONE) ++ gtk_entry_update_handles (entry, GTK_TEXT_HANDLE_MODE_CURSOR); ++ } ++} ++ + static void + gtk_entry_delete_cb (GtkEntry *entry) + { +diff -ur gtk+-3.24.1/gtk/gtkentry.h gtk+-3.24.1_patched/gtk/gtkentry.h +--- gtk+-3.24.1/gtk/gtkentry.h 2017-11-27 00:24:51.000000000 +0100 ++++ gtk+-3.24.1_patched/gtk/gtkentry.h 2019-03-24 11:55:03.848566726 +0100 +@@ -145,6 +145,7 @@ + void (* cut_clipboard) (GtkEntry *entry); + void (* copy_clipboard) (GtkEntry *entry); + void (* paste_clipboard) (GtkEntry *entry); ++ void (* paste_selection) (GtkEntry *entry); + void (* toggle_overwrite) (GtkEntry *entry); + + /* hooks to add other objects beside the entry (like in GtkSpinButton) */ +@@ -168,7 +169,6 @@ + void (*_gtk_reserved3) (void); + void (*_gtk_reserved4) (void); + void (*_gtk_reserved5) (void); +- void (*_gtk_reserved6) (void); + }; + + GDK_AVAILABLE_IN_ALL +diff -ur gtk+-3.24.1/gtk/gtktextview.c gtk+-3.24.1_patched/gtk/gtktextview.c +--- gtk+-3.24.1/gtk/gtktextview.c 2018-07-25 14:29:25.000000000 +0200 ++++ gtk+-3.24.1_patched/gtk/gtktextview.c 2019-03-24 11:46:29.476553772 +0100 +@@ -327,6 +327,7 @@ + CUT_CLIPBOARD, + COPY_CLIPBOARD, + PASTE_CLIPBOARD, ++ PASTE_SELECTION, + TOGGLE_OVERWRITE, + MOVE_VIEWPORT, + SELECT_ALL, +@@ -497,6 +498,7 @@ + static void gtk_text_view_cut_clipboard (GtkTextView *text_view); + static void gtk_text_view_copy_clipboard (GtkTextView *text_view); + static void gtk_text_view_paste_clipboard (GtkTextView *text_view); ++static void gtk_text_view_paste_selection (GtkTextView *text_view); + static void gtk_text_view_toggle_overwrite (GtkTextView *text_view); + static void gtk_text_view_toggle_cursor_visible (GtkTextView *text_view); + +@@ -785,6 +787,7 @@ + klass->cut_clipboard = gtk_text_view_cut_clipboard; + klass->copy_clipboard = gtk_text_view_copy_clipboard; + klass->paste_clipboard = gtk_text_view_paste_clipboard; ++ klass->paste_selection = gtk_text_view_paste_selection; + klass->toggle_overwrite = gtk_text_view_toggle_overwrite; + klass->create_buffer = gtk_text_view_create_buffer; + klass->extend_selection = gtk_text_view_extend_selection; +@@ -1305,6 +1308,15 @@ + NULL, + G_TYPE_NONE, 0); + ++ signals[PASTE_SELECTION] = ++ g_signal_new (I_("paste-selection"), ++ G_OBJECT_CLASS_TYPE (gobject_class), ++ G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION, ++ G_STRUCT_OFFSET (GtkTextViewClass, paste_selection), ++ NULL, NULL, ++ NULL, ++ G_TYPE_NONE, 0); ++ + /** + * GtkTextView::toggle-overwrite: + * @text_view: the object which received the signal +@@ -1652,14 +1664,14 @@ + gtk_binding_entry_add_signal (binding_set, GDK_KEY_KP_Insert, GDK_CONTROL_MASK, + "copy-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_KP_Insert, GDK_SHIFT_MASK, +- "paste-clipboard", 0); ++ "paste-selection", 0); + + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Delete, GDK_SHIFT_MASK, + "cut-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, GDK_CONTROL_MASK, + "copy-clipboard", 0); + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, GDK_SHIFT_MASK, +- "paste-clipboard", 0); ++ "paste-selection", 0); + + /* Overwrite */ + gtk_binding_entry_add_signal (binding_set, GDK_KEY_Insert, 0, +@@ -7221,6 +7233,19 @@ + } + + static void ++gtk_text_view_paste_selection (GtkTextView *text_view) ++{ ++ GtkClipboard *clipboard = gtk_widget_get_clipboard (GTK_WIDGET (text_view), ++ GDK_SELECTION_PRIMARY); ++ ++ text_view->priv->scroll_after_paste = TRUE; ++ gtk_text_buffer_paste_clipboard (get_buffer (text_view), ++ clipboard, ++ NULL, ++ text_view->priv->editable); ++} ++ ++static void + gtk_text_view_paste_done_handler (GtkTextBuffer *buffer, + GtkClipboard *clipboard, + gpointer data) +diff -ur gtk+-3.24.1/gtk/gtktextview.h gtk+-3.24.1_patched/gtk/gtktextview.h +--- gtk+-3.24.1/gtk/gtktextview.h 2017-11-26 22:31:46.000000000 +0100 ++++ gtk+-3.24.1_patched/gtk/gtktextview.h 2019-03-24 11:57:41.592570698 +0100 +@@ -181,6 +181,7 @@ + void (* cut_clipboard) (GtkTextView *text_view); + void (* copy_clipboard) (GtkTextView *text_view); + void (* paste_clipboard) (GtkTextView *text_view); ++ void (* paste_selection) (GtkTextView *text_view); + void (* toggle_overwrite) (GtkTextView *text_view); + GtkTextBuffer * (* create_buffer) (GtkTextView *text_view); + void (* draw_layer) (GtkTextView *text_view, +@@ -199,7 +200,6 @@ + void (*_gtk_reserved1) (void); + void (*_gtk_reserved2) (void); + void (*_gtk_reserved3) (void); +- void (*_gtk_reserved4) (void); + }; + + GDK_AVAILABLE_IN_ALL