From e89ad77b51faf3fe0d086e78b73ecdaadeff592f Mon Sep 17 00:00:00 2001
From: gryf <git@vimja.com>
Date: Sun, 2 Oct 2022 10:14:46 +0200
Subject: [PATCH] Separate uadf from extfslib

---
 README.rst  |  98 +++------------------
 extfslib.py | 241 ----------------------------------------------------
 ulha        | 182 ---------------------------------------
 ulzx        | 135 -----------------------------
 4 files changed, 10 insertions(+), 646 deletions(-)
 delete mode 100644 extfslib.py
 delete mode 100755 ulha
 delete mode 100755 ulzx

diff --git a/README.rst b/README.rst
index 508f4dc..fae1cc3 100644
--- a/README.rst
+++ b/README.rst
@@ -1,96 +1,14 @@
-========================
-Midnight Commander extfs
-========================
+=======================
+Midnight Commander uadf
+=======================
 
-Those are Midnight Commander extfs plugins for handling several archive types
-mostly known from AmigaOS - like **lha**, **lzx** and disk images like **adf**
-and **dms**.
-
-Installation
-============
-
-See individual installation plugins below. Basically it comes down to:
-
-* copying ``extfslib.py`` and plugin files to ``~/.local/share/mc/extfs.d/``
-* installing binary handlers (lha, unlzx, xdms and unadf)
-* adding an entry in ``~/.config/mc/mc.ext``::
-
-    # arch
-    regex/\.pattern$
-         Open=%cd %p/handler_filename://
-
-ULha
-====
-
-ULha is an extfs plugin which can be used with lha/lzh/lharc archives.
-Personally, I've use it almost exclusively for archives created long time ago
-on my Amiga. Both reading from and writing into archive was implemented.
-
-Requirements
-------------
-
-ULha requires `free lha <http://lha.sourceforge.jp>`_ implementation to work.
-
-Installation
-------------
-
-* copy ``extfslib.py`` and ``ulha`` to ``~/.local/share/mc/extfs.d/``
-* add or change entry for files handle in ``~/.config/mc/mc.ext``::
-
-    # lha
-    regex/\.[lL]([Hh][aA]|[Zz][hH])$
-         Open=%cd %p/ulha://
-         View=%view{ascii} lha l %f
-
-ULzx
-====
-
-ULzx is an extfs plugin which can be used to browse and extract lzx archives,
-which are known almost exclusively from Amiga.
-
-Due to limitations of
-`unlzx <ftp://us.aminet.net/pub/aminet/misc/unix/unlzx.c.gz.readme>`_ tools,
-only reading is supported. Also be aware, that
-`unlzx <ftp://us.aminet.net/pub/aminet/misc/unix/unlzx.c.gz.readme>`_ cannot
-extract files individually, so copying entire archive content is not
-recommended, since on every single file a full archive extract would be
-performed, which in the end would have impact on performance.
-
-Requirements
-------------
-
-ULzx requires
-`unlzx <ftp://us.aminet.net/pub/aminet/misc/unix/unlzx.c.gz.readme>`_ tool.
-
-Installation
-------------
-
-* copy ``extfslib.py`` and ``ulzx`` to ``~/.local/share/mc/extfs.d/``
-* add or change entry for files handle in ``~/.config/mc/mc.ext``::
-
-    # lzx
-    regex/\.[lL][zZ][xX]$
-         Open=%cd %p/ulzx://
-         View=%view{ascii} unlzx -v %f
-
-UAdf
-====
-
-UAdf is an extfs plugin suitable for reading .adf, .adz and .dms Amiga floppy
-disk images. Due to limitations of the
-`unadf <http://freecode.com/projects/unadf>`_, file access inside disk image is
-read only.
-
-In case of corrupted or no-dos images, message will be shown.
+Midnight Commander extfs plugin for handling Amiga adf/dms floppy images.
 
 Requirements
 ------------
 
 It requires ``unadf`` utility from `ADFlib <https://github.com/lclevy/ADFlib>`_
-repository, with included `that commit
-<https://github.com/lclevy/ADFlib/commit/d36dc2f395f3e8fcee81f66bc86994e166b6140f>`_
-in particular, which introduced separation between filename and comment
-attribute on Amiga Fast File System.
+repository.
 
 If it turns out that your distribution doesn't provide proper version of ADFlib,
 there will be a need for building it by hand.
@@ -131,7 +49,8 @@ needed.
 Installation
 ------------
 
-* copy ``extfslib.py`` and ``uadf`` to ``~/.local/share/mc/extfs.d/``
+* install `extfslib`_
+* copy ``uadf`` to ``~/.local/share/mc/extfs.d/``
 * add or change entry for files handle in ``~/.config/mc/mc.ext``::
 
     # adf
@@ -152,3 +71,6 @@ License
 
 This software is licensed under 3-clause BSD license. See LICENSE file for
 details.
+
+
+.. _extfslib: https://github.com/gryf/mc_extfs
diff --git a/extfslib.py b/extfslib.py
deleted file mode 100644
index d828cf5..0000000
--- a/extfslib.py
+++ /dev/null
@@ -1,241 +0,0 @@
-"""
-extfslib is a library which contains Archive class to support writing extfs
-plugins for Midnight Commander.
-
-Tested against python 3.6 and mc 4.8.22
-
-Changelog:
-    1.2 Switch to python3
-    1.1 Added item pattern, and common git/uid attrs
-    1.0 Initial release
-
-Author: Roman 'gryf' Dobosz <gryf73@gmail.com>
-Date: 2019-06-30
-Version: 1.2
-Licence: BSD
-"""
-import argparse
-import os
-import sys
-import re
-from subprocess import check_output, CalledProcessError
-
-
-class Archive(object):
-    """Archive handle. Provides interface to MC's extfs subsystem"""
-    LINE_PAT = re.compile(b"^(?P<size>)\s"
-                          b"(?P<perms>)\s"
-                          b"(?P<uid>)\s"
-                          b"(?P<gid>)\s"
-                          b"(?P<date>)\s+"
-                          b"(?P<time>)\s"
-                          b"(?P<fpath>)")
-    ARCHIVER = b"archiver_name"
-    CMDS = {"list": b"l",
-            "read": b"r",
-            "write": b"w",
-            "delete": b"d"}
-    ITEM = (b"%(perms)s   1 %(uid)-8s %(gid)-8s %(size)8s %(datetime)s "
-            b"%(display_name)s\n")
-
-    def __init__(self, fname):
-        """Prepare archive content for operations"""
-        if not os.path.exists(fname):
-            raise OSError("No such file or directory `%s'" % fname)
-        self._uid = os.getuid()
-        self._gid = os.getgid()
-        self._arch = fname
-        self.name_map = {}
-        self._contents = self._get_dir()
-
-    def _map_name(self, name):
-        """MC still have a bug in extfs subsystem, in case of filepaths with
-        leading space. This is workaround to this bug, which replaces leading
-        space with tilda."""
-        if name.startswith(b" "):
-            new_name = b"".join([b"~", name[1:]])
-            return new_name
-        return name
-
-    def _get_real_name(self, name):
-        """Get real filepath of the file. See _map_name docstring for
-        details."""
-        for item in self._contents:
-            if item[b'display_name'] == name.encode('utf-8',
-                                                    'surrogateescape'):
-                return item[b'fpath']
-        return None
-
-    def _get_dir(self):
-        """Prepare archive file listing. Expected keys which every entry
-        should have are: size, perms, uid, gid, date, time, fpath and
-        display_name."""
-        contents = []
-
-        out = self._call_command("list")
-        if not out:
-            return
-
-        for line in out.split(b"\n"):
-            match = self.LINE_PAT.match(line)
-            if not match:
-                continue
-            entry = match.groupdict()
-            contents.append(entry)
-
-        return contents
-
-    def _call_command(self, cmd, src=None, dst=None):
-        """
-        Return status of the provided command, which can be one of:
-            write
-            read
-            delete
-            list
-        """
-        command = [self.ARCHIVER, self.CMDS.get(cmd), self._arch]
-
-        if src and dst:
-            command.append(src)
-            command.append(dst)
-        elif src or dst:
-            command.append(src and src or dst)
-
-        try:
-            output = check_output(command)
-        except CalledProcessError:
-            sys.exit(1)
-        return output
-
-    def list(self):
-        """Output contents of the archive to stdout"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def run(self, dst):
-        """Execute file out of archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def copyout(self, src, dst):
-        """Copy file out of archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def rm(self, dst):
-        """Remove file from archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def mkdir(self, dst):
-        """Create empty directory in archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def rmdir(self, dst):
-        """Removes directory from archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-    def copyin(self, dst, src=None):
-        """Copy file to the archive"""
-        sys.stderr.write("Not supported")
-        return 1
-
-
-def usage():
-    """Print out usage information"""
-    print ("Usage: %(prg)s {copyin,copyout} ARCHNAME SOURCE DESTINATION\n"
-           "or: %(prg)s list ARCHNAME\n"
-           "or: %(prg)s {mkdir,rm,rmdir,run} ARCHNAME TARGET" %
-           {"prg": sys.argv[0]})
-
-
-def _parse_args(arch_class):
-    """Use ArgumentParser to check for script arguments and execute."""
-
-    CALL_MAP = {'list': lambda a: arch_class(a.arch).list(),
-                'copyin': lambda a: arch_class(a.arch).copyin(a.src, a.dst),
-                'copyout': lambda a: arch_class(a.arch).copyout(a.src, a.dst),
-                'mkdir': lambda a: arch_class(a.arch).mkdir(a.dst),
-                'rm': lambda a: arch_class(a.arch).rm(a.dst),
-                'run': lambda a: arch_class(a.arch).run(a.dst)}
-
-    parser = argparse.ArgumentParser()
-    subparsers = parser.add_subparsers(help='supported commands')
-    parser_list = subparsers.add_parser('list', help="List contents of "
-                                        "archive")
-    parser_copyin = subparsers.add_parser('copyin', help="Copy file into "
-                                          "archive")
-    parser_copyout = subparsers.add_parser('copyout', help="Copy file out of "
-                                           "archive")
-    parser_rm = subparsers.add_parser('rm', help="Delete file from archive")
-    parser_mkdir = subparsers.add_parser('mkdir', help="Create directory in "
-                                         "archive")
-    parser_run = subparsers.add_parser('run', help="Execute archived file")
-
-    parser_list.add_argument('arch', help="Archive filename")
-    parser_list.set_defaults(func=CALL_MAP['list'])
-
-    parser_copyin.add_argument('arch', help="Archive filename")
-    parser_copyin.add_argument('src', help="Source filename")
-    parser_copyin.add_argument('dst', help="Destination filename (to be "
-                               "written into archive)")
-    parser_copyin.set_defaults(func=CALL_MAP['copyin'])
-
-    parser_copyout.add_argument('arch', help="D64 Image filename")
-    parser_copyout.add_argument('src', help="Source filename (to be read from"
-                                " archive")
-    parser_copyout.add_argument('dst', help="Destination filename")
-    parser_copyout.set_defaults(func=CALL_MAP['copyout'])
-
-    parser_rm.add_argument('arch', help="D64 Image filename")
-    parser_rm.add_argument('dst', help="File inside archive to be deleted")
-    parser_rm.set_defaults(func=CALL_MAP['rm'])
-
-    parser_mkdir.add_argument('arch', help="archive filename")
-    parser_mkdir.add_argument('dst', help="Directory name inside archive to "
-                              "be created")
-    parser_mkdir.set_defaults(func=CALL_MAP['mkdir'])
-
-    parser_run.add_argument('arch', help="archive filename")
-    parser_run.add_argument('dst', help="File to be executed")
-    parser_run.set_defaults(func=CALL_MAP['run'])
-
-    args = parser.parse_args()
-    return args.func(args)
-
-
-def parse_args(arch_class):
-    """Retrive and parse arguments from commandline and apply them into passed
-    arch_class class object."""
-    try:
-        if sys.argv[1] not in ('list', 'copyin', 'copyout', 'rm', 'mkdir',
-                               "run", "rmdir"):
-            usage()
-            sys.exit(2)
-    except IndexError:
-        usage()
-        sys.exit(2)
-
-    arch = src = dst = None
-    try:
-        arch = sys.argv[2]
-        if sys.argv[1] in ('copyin', 'copyout'):
-            src = sys.argv[3]
-            dst = sys.argv[4]
-        elif sys.argv[1] in ('rm', 'rmdir', 'run', 'mkdir'):
-            dst = sys.argv[3]
-    except IndexError:
-        usage()
-        sys.exit(2)
-
-    call_map = {'copyin': lambda a, s, d: arch_class(a).copyin(s, d),
-                'copyout': lambda a, s, d: arch_class(a).copyout(s, d),
-                'list': lambda a, s, d: arch_class(a).list(),
-                'mkdir': lambda a, s, d: arch_class(a).mkdir(d),
-                'rm': lambda a, s, d: arch_class(a).rm(d),
-                'rmdir': lambda a, s, d: arch_class(a).rmdir(d),
-                'run': lambda a, s, d: arch_class(a).run(d)}
-
-    return call_map[sys.argv[1]](arch, src, dst)
diff --git a/ulha b/ulha
deleted file mode 100755
index 5158124..0000000
--- a/ulha
+++ /dev/null
@@ -1,182 +0,0 @@
-#!/usr/bin/env python3
-"""
-Lha Virtual filesystem executive for Midnight Commander.
-
-Tested against python 3.6, lha[1] 1.14 and mc 4.8.22
-
-[1] http://lha.sourceforge.jp
-
-Changelog:
-    1.3 Switch to python3
-    1.2 Moved item pattern to extfslib module
-    1.1 Moved common code into extfslib library
-    1.0 Initial release
-
-Author: Roman 'gryf' Dobosz <gryf73@gmail.com>
-Date: 2019-06-30
-Version: 1.3
-Licence: BSD
-"""
-import os
-import sys
-import re
-import shutil
-from subprocess import call, check_call, CalledProcessError
-from tempfile import mkdtemp, mkstemp
-
-from extfslib import Archive, parse_args
-
-
-class ULha(Archive):
-    """Archive handle. Provides interface to MC's extfs subsystem"""
-
-    LINE_PAT = re.compile(b"^((?P<perms>[d-][rswx-]{9})|(\[generic\])|"
-                          b"(\[unknown\]))"
-                          b"((\s+\d+/\d+\s+)|(\s+))"
-                          b"(?P<uid>)(?P<gid>)"  # just for the record
-                          b"(?P<size>\d+)"
-                          b"\s+(\*{6}|\d+\.\d%)"
-                          b"\s(?P<month>[JFMASOND][a-z]{2})\s+"  # month
-                          b"(?P<day>\d+)\s+"  # day
-                          b"(?P<yh>\d{4}|(\d{2}:\d{2}))"  # year/hour
-                          b"\s(?P<fpath>.*)")
-    ARCHIVER = b"lha"
-    CMDS = {"list": b"lq",
-            "read": b"pq",
-            "write": b"aq",
-            "delete": b"dq"}
-    DATETIME = b"%(month)s %(day)s %(yh)s"
-
-    def _get_dir(self):
-        """Prepare archive file listing"""
-        contents = []
-
-        out = self._call_command("list")
-        if not out:
-            return
-
-        for line in out.split(b"\n"):
-            # -lhd- can store empty directories
-            perms = b"-rw-r--r--"
-            if line.endswith(bytes(os.path.sep, 'utf-8')):
-                line = line[:-1]
-                perms = b"drw-r--r--"
-
-            match = self.LINE_PAT.match(line)
-            if not match:
-                continue
-
-            match_entry = match.groupdict()
-            entry = {}
-            for key in match_entry:
-                entry[bytes(key, 'utf-8')] = match_entry[key]
-            del match_entry
-            # UID and GID sometimes can have strange values depending on
-            # the information that was written into archive. Most of the
-            # times I was dealing with Amiga lha archives, so that i don't
-            # really care about real user/group
-
-            entry[b'uid'] = bytes(str(self._uid), 'utf-8')
-            entry[b'gid'] = bytes(str(self._gid), 'utf-8')
-            entry[b'datetime'] = self.DATETIME % entry
-
-            if not entry[b'perms']:
-                entry[b'perms'] = perms
-
-            entry[b'display_name'] = self._map_name(entry[b'fpath'])
-            contents.append(entry)
-
-        return contents
-
-    def list(self):
-        """Output contents of the archive to stdout"""
-        for entry in self._contents:
-            sys.stdout.buffer.write(self.ITEM % entry)
-        return 0
-
-    def rm(self, dst):
-        """Remove file from archive"""
-        dst = self._get_real_name(dst)
-        # deleting with quiet option enabled will output nothing, so we get
-        # empty string here or None in case of error. Not smart.
-        if self._call_command('delete', dst=dst) is None:
-            return 1
-        return 0
-
-    def rmdir(self, dst):
-        """Remove empty directory"""
-        dst = self._get_real_name(dst)
-
-        if not dst.endswith(bytes(os.path.sep, 'utf-8')):
-            dst += bytes(os.path.sep, 'utf-8')
-
-        if self._call_command('delete', dst=dst) is None:
-            return 1
-        return 0
-
-    def run(self, dst):
-        """Execute file out of archive"""
-        fdesc, tmp_file = mkstemp()
-        os.close(fdesc)
-        result = 0
-
-        if self.copyout(dst, tmp_file) != 0:
-            result = 1
-
-        os.chmod(tmp_file, int("700", 8))
-
-        try:
-            result = call([tmp_file])
-        finally:
-            try:
-                os.unlink(tmp_file)
-            except OSError:
-                pass
-
-        return result
-
-    def mkdir(self, dst):
-        """Create empty directory in archive"""
-        return self.copyin(dst)
-
-    def copyin(self, dst, src=None):
-        """Copy file to the archive or create direcotry inside.
-        If src is empty, create empty directory with dst name."""
-        current_dir = os.path.abspath(os.curdir)
-
-        tmpdir = mkdtemp()
-        arch_abspath = os.path.realpath(self._arch)
-        os.chdir(tmpdir)
-        if src:
-            os.makedirs(os.path.dirname(dst))
-            shutil.copy2(src, dst)
-        else:
-            os.makedirs(dst)
-
-        try:
-            result = check_call([self.ARCHIVER.decode('utf-8'),
-                                 self.CMDS["write"].decode('utf-8'),
-                                 arch_abspath, dst])
-        except CalledProcessError:
-            return 1
-        finally:
-            os.chdir(current_dir)
-            shutil.rmtree(tmpdir)
-        return result
-
-    def copyout(self, src, dst):
-        """Copy file out form archive."""
-        src = self._get_real_name(src)
-        fobj = open(dst, "wb")
-        try:
-            result = check_call([self.ARCHIVER, self.CMDS['read'], self._arch,
-                                 src], stdout=fobj)
-        except CalledProcessError:
-            return 1
-        finally:
-            fobj.close()
-        return result
-
-
-if __name__ == "__main__":
-    sys.exit(parse_args(ULha))
diff --git a/ulzx b/ulzx
deleted file mode 100755
index 594d9cf..0000000
--- a/ulzx
+++ /dev/null
@@ -1,135 +0,0 @@
-#!/usr/bin/env python3
-"""
-Read only, Amiga LZX[1] archiver Virtual filesystem executive for Midnight
-Commander.
-
-Tested against python 3.6, unlzx[1] 1.1 and mc 4.8.22
-
-[1] ftp://us.aminet.net/pub/aminet/misc/unix/unlzx.c.gz.readme
-
-Changelog:
-    1.2 Use python3
-    1.1 Moved common code into extfslib library
-    1.0 Initial release
-
-Author: Roman 'gryf' Dobosz <gryf73@gmail.com>
-Date: 2019-06-30
-Version: 1.2
-Licence: BSD
-"""
-import os
-import sys
-import re
-import shutil
-from subprocess import call, CalledProcessError
-from tempfile import mkdtemp, mkstemp
-
-from extfslib import Archive, parse_args
-
-
-class ULzx(Archive):
-    """Archive handle. Provides interface to MC's extfs subsystem"""
-    LINE_PAT = re.compile(b"^\s+(?P<size>\d+)\s+"
-                          b"((n/a)|\d+)\s"
-                          b"(?P<time>\d{2}:\d{2}:\d{2})\s+"
-                          b"(?P<date>\d+-[a-z]{3}-\d{4})\s"
-                          b"(?P<perms>[h-][s-][p-][a-][r-][w-][e-][d-])\s"
-                          b"\"(?P<fpath>.*)\"")
-    ARCHIVER = b"unlzx"
-    CMDS = {"list": b"-v",
-            "read": b"-x"}
-    DATETIME = b"%02d-%02d-%s %02d:%02d"
-
-    def _get_date(self, time, date):
-        """Return MM-DD-YYYY hh:mm formatted date out of time and date
-        strings"""
-        month_list = [b"jan", b"feb", b"mar", b"apr", b"may", b"jun", b"jul",
-                      b"aug", b"sep", b"oct", b"nov", b"dec"]
-        day, month, year = date.split(b"-")
-        month = month_list.index(month) + 1
-        hours, minutes, dummy = time.split(b":")
-        return self.DATETIME % (month, int(day), year, int(hours),
-                                int(minutes))
-
-    def _get_dir(self):
-        """Prepare archive file listing"""
-        contents = []
-
-        out = self._call_command("list")
-        if not out:
-            return
-
-        for line in out.split(b"\n"):
-            match = self.LINE_PAT.match(line)
-            if not match:
-                continue
-
-            match_entry = match.groupdict()
-            entry = {}
-            for key in match_entry:
-                entry[bytes(key, 'utf-8')] = match_entry[key]
-            del match_entry
-
-            entry[b'datetime'] = self._get_date(entry[b'time'], entry[b'date'])
-            entry[b'display_name'] = self._map_name(entry[b'fpath'])
-            entry[b'perms'] = b"-rw-r--r--"  # lzx doesn't store empty dirs
-            entry[b'uid'] = bytes(str(self._uid), 'utf-8')
-            entry[b'gid'] = bytes(str(self._gid), 'utf-8')
-            contents.append(entry)
-
-        return contents
-
-    def list(self):
-        """Output contents of the archive to stdout"""
-        for entry in self._contents:
-            sys.stdout.buffer.write(self.ITEM % entry)
-        return 0
-
-    def run(self, dst):
-        """Execute file out of archive"""
-        fdesc, tmp_file = mkstemp()
-        os.close(fdesc)
-        result = 0
-
-        if self.copyout(dst, tmp_file) != 0:
-            result = 1
-
-        os.chmod(tmp_file, int("700", 8))
-
-        try:
-            result = call([tmp_file])
-        finally:
-            try:
-                os.unlink(tmp_file)
-            except OSError:
-                pass
-
-        return result
-
-    def copyout(self, src, dst):
-        """Unfortunately, to copy one file out entire LZX archive have to be
-        extracted. For small archives is not a problem, but in relatively big
-        one it could be a performance issue."""
-        tmp_dir = mkdtemp()
-        src = self._get_real_name(src)
-        current_dir = os.path.abspath(os.curdir)
-        os.chdir(tmp_dir)
-
-        try:
-            with open(os.devnull, "w") as fnull:
-                result = call([self.ARCHIVER, self.CMDS['read'],
-                               os.path.join(current_dir, self._arch)],
-                              stdout=fnull, stderr=fnull)
-            if result == 0:
-                shutil.copy2(src, dst)
-        except CalledProcessError:
-            return 1
-        finally:
-            shutil.rmtree(tmp_dir)
-            os.chdir(current_dir)
-
-        return result
-
-
-if __name__ == "__main__":
-    sys.exit(parse_args(ULzx))