gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-23 05:57:58 +01:00
Code Issues Projects Releases Wiki Activity

vimperator 1.1 with security fix

Browse Source
This commit is contained in:
Martin Stubenschrott
2008-06-03 17:09:30 +00:00
parent 3157772347
commit 02be238e3b
4 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
content/completion.js
View File

@@ -35,6 +35,9 @@ liberator.Completion = function () //{{{
// the completion substrings, used for showing the longest common match
var substrings = [];
// import JSON module, needed for secure JSON parsing
Components.utils.import("resource://gre/modules/JSON.jsm");
// function uses smartcase
// list = [ [['com1', 'com2'], 'text'], [['com3', 'com4'], 'text'] ]
function buildLongestCommonSubstring(list, filter)
@@ -207,13 +210,19 @@ liberator.Completion = function () //{{{
var xhr = new XMLHttpRequest();
xhr.open("GET", queryURI, false);
xhr.send(null);
var results = window.eval(xhr.responseText)[1];
var results = JSON.fromString(xhr.responseText)[1];
if (!results)
return;
results.forEach(function (item)
{
completions.push([(matches ? matches[1] : "") + item, name + " suggestion"]);
// make sure we receive strings, otherwise a man-in-the-middle attack
// could return objects which toString() method could be called to
// execute untrusted code
if(typeof(item) != "string")
return;
completions.push([(matches ? matches[1] : "") + item, engine.name + " suggestion"]);
});
});