gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 14:27:59 +01:00
Code Issues Projects Releases Wiki Activity

Restore beeping at buffer scroll boundaries.

Browse Source
This commit is contained in:
Doug Kearns
2010-10-06 23:51:41 +11:00
parent f17790a39a
commit 033ad14e75
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
common/content/buffer.js
View File

@@ -742,12 +742,10 @@ const Buffer = Module("buffer", {
count = count || 1;
let win = Buffer.findScrollableWindow();
Buffer.checkScrollYBounds(win, direction);
if (options["scroll"] > 0)
this.scrollLines(options["scroll"] * direction);
else // scroll half a page down in pixels
win.scrollBy(0, win.innerHeight / 2 * direction);
else
this.scrollPages(direction / 2);
},
_scrollByScrollSize: function _scrollByScrollSize(count, direction) {
@@ -1107,12 +1105,6 @@ const Buffer = Module("buffer", {
Buffer.setZoom(Math.round(values[i] * 100), fullZoom);
},
checkScrollYBounds: function checkScrollYBounds(win, direction) {
// NOTE: it's possible to have scrollY > scrollMaxY - FF bug?
if (direction > 0 && win.scrollY >= win.scrollMaxY || direction < 0 && win.scrollY == 0)
dactyl.beep();
},
findScrollableWindow: function findScrollableWindow() {
win = window.document.commandDispatcher.focusedWindow;
if (win && (win.scrollMaxX > 0 || win.scrollMaxY > 0))
@@ -1176,8 +1168,12 @@ const Buffer = Module("buffer", {
else
throw Error();
elem.scrollTop += number * increment;
if (number < 0 ? elem.scrollTop > 0 : elem.scrollTop < elem.scrollHeight - elem.clientHeight)
elem.scrollTop += number * increment;
else
dactyl.beep();
},
scrollHorizontal: function scrollHorizontal(elem, increment, number) {
elem = elem || Buffer.findScrollable(number, true);
let fontSize = parseInt(util.computedStyle(elem).fontSize);
@@ -1188,7 +1184,10 @@ const Buffer = Module("buffer", {
else
throw Error();
elem.scrollLeft += number * increment;
if (number < 0 ? elem.scrollLeft > 0 : elem.scrollLeft < elem.scrollWidth - elem.clientWidth)
elem.scrollLeft += number * increment;
else
dactyl.beep();
},
scrollElemToPercent: function scrollElemToPercent(elem, horizontal, vertical) {