From e2e952b0083f89fa3bb5b96db323dcc3c3b0c240 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Tue, 8 Feb 2011 23:07:22 -0500 Subject: [PATCH 1/3] Fix extension completion bug. --- common/modules/addons.jsm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/modules/addons.jsm b/common/modules/addons.jsm index 3824f149..67d3136a 100644 --- a/common/modules/addons.jsm +++ b/common/modules/addons.jsm @@ -455,8 +455,8 @@ var Addons = Module("addons", { context.title = ["Extension"]; context.anchored = false; context.keys = { text: "name", description: "description", icon: "iconURL" }, - context.incomplete = true; context.generate = function () { + context.incomplete = true; AddonManager.getAddonsByTypes(types || ["extension"], function (addons) { context.incomplete = false; context.completions = addons; From 6058a18aa7405bef1b84ebce2ec7c857ae9f3b7a Mon Sep 17 00:00:00 2001 From: Anthony Martin Date: Wed, 9 Feb 2011 15:19:34 -0800 Subject: [PATCH 2/3] Check wildmode for completion list visibility in reset. --- common/content/commandline.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/content/commandline.js b/common/content/commandline.js index af0a70a3..e71a1c45 100644 --- a/common/content/commandline.js +++ b/common/content/commandline.js @@ -1132,7 +1132,8 @@ var CommandLine = Module("commandline", { if (show) { this.itemList.reset(); - this.itemList.visible = true; + if (this.haveType("list")) + this.itemList.visible = true; this.selected = null; this.wildIndex = 0; } From 1bf7d7f1c30a8fbb6a8b914491c6d042f1b7b92f Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Fri, 11 Feb 2011 00:45:00 -0500 Subject: [PATCH 3/3] Deal with autocomplete fallout from imported patch. --- common/content/commandline.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/content/commandline.js b/common/content/commandline.js index e71a1c45..595f8da4 100644 --- a/common/content/commandline.js +++ b/common/content/commandline.js @@ -326,8 +326,8 @@ var CommandMode = Class("CommandMode", { if (this.complete) this.completions = CommandLine.Completions(commandline.widgets.active.command.inputField, this); - if (this.completions && command && options["autocomplete"].length && commandline.commandSession === this) - this.completions.complete(true, false); + if (this.completions && command && commandline.commandSession === this) + this.completions.autocompleteTimer.flush(true); }, get holdFocus() this.widgets.active.command.inputField,