gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-01-08 07:14:17 +01:00
Code Issues Projects Releases Wiki Activity

Quick fix for #291 (tabline does not stay hidden).

Browse Source 
This still isn't quite right but matches the behaviour of the 2.1
release.
This commit is contained in:
Doug Kearns
2009-06-10 15:13:20 +10:00
parent 3fde53ab9d
commit 12feff7eb9
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
common/content/tabs.js
View File

@@ -113,7 +113,7 @@ function Tabs() //{{{
// hide tabs initially to prevent flickering when 'stal' would hide them // hide tabs initially to prevent flickering when 'stal' would hide them
// on startup // on startup
if (config.hasTabbrowser) if (config.hasTabbrowser)
getBrowser().mStrip.collapsed = true; getBrowser().mTabContainer.collapsed = true; // FIXME: see 'stal' comment
/////////////////////////////////////////////////////////////////////////////}}} /////////////////////////////////////////////////////////////////////////////}}}
////////////////////// OPTIONS ///////////////////////////////////////////////// ////////////////////// OPTIONS /////////////////////////////////////////////////
@@ -125,15 +125,18 @@ function Tabs() //{{{
{ {
setter: function (value) setter: function (value)
{ {
let tabStrip = tabs.tabStrip; // FIXME: we manipulate mTabContainer underneath mStrip so we
// don't have to fight against the host app's attempts to keep
if (!tabStrip) // it open - hack! Adding a filter watch to mStrip is probably
return options["showtabline"]; // XXX // the cleanest solution.
let tabStrip = getBrowser().mTabContainer;
if (value == 0) if (value == 0)
tabStrip.collapsed = true; tabStrip.collapsed = true;
else else
{ {
// FIXME: Why are we preferring our own created preference
// here? --djk
let pref = "browser.tabStrip.autoHide"; let pref = "browser.tabStrip.autoHide";
if (options.getPref(pref) == null) // Try for FF 3.0 & 3.1 if (options.getPref(pref) == null) // Try for FF 3.0 & 3.1
pref = "browser.tabs.autoHide"; pref = "browser.tabs.autoHide";
@@ -739,11 +742,6 @@ function Tabs() //{{{
*/ */
get localStore() this.getLocalStore(), get localStore() this.getLocalStore(),
/**
* @property {Object} The tab browser strip.
*/
get tabStrip() getBrowser().mStrip,
/** /**
* @property {Object[]} The array of closed tabs for the current * @property {Object[]} The array of closed tabs for the current
* session. * session.

1
vimperator/TODO
View File

@@ -16,6 +16,7 @@ BUGS:
- :sidebar improvements (:sidebar! Downloads while downloads is open should refocus the sidebar) - :sidebar improvements (:sidebar! Downloads while downloads is open should refocus the sidebar)
- ;s saves the page rather than the image - ;s saves the page rather than the image
- RC file is sourced once per window - RC file is sourced once per window
- :undo seems to be effected by whether the tabstrip state
(recent CVS regressions): (recent CVS regressions):
- visual caret mode is broken, requires a manual page focus first anyway or - visual caret mode is broken, requires a manual page focus first anyway or