From 147be2614c1260d24b646875645ddde2aa021f39 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Wed, 7 Jan 2015 17:10:03 -0800 Subject: [PATCH] Filter out duplicate search strings from search keyword term history completion. --- common/content/bookmarks.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/content/bookmarks.js b/common/content/bookmarks.js index edad3d49..1754ac05 100644 --- a/common/content/bookmarks.js +++ b/common/content/bookmarks.js @@ -695,13 +695,15 @@ var Bookmarks = Module("bookmarks", { context.generate = function () { let [begin, end] = item.url.split("%s"); + let seen = RealSet(); return history.get({ uri: util.newURI(begin), uriIsPrefix: true }).map(function (item) { let rest = item.url.length - end.length; let query = item.url.substring(begin.length, rest); if (item.url.substr(rest) == end && query.contains("&")) try { item.url = decodeURIComponent(query.replace(/[&#].*/, "").replace(/\+/g, " ")); - return item; + if (!seen.add(item.url)) + return item; } catch (e) {} return null;