diff --git a/HACKING b/HACKING index bf24f6aa..bc193b4d 100644 --- a/HACKING +++ b/HACKING @@ -138,6 +138,14 @@ We try to be quite consistent, but of course, that's not always possible. new immediately, but will probably do so over time, when I see it. --mst + Actually, you're not sure of anything. You can call new (function (a) + a.substr(2)), and you don't get a new object. The only difference is + that it's called with 'this' set. Given that it's uncouth to name a + non-constructor function in CamelCase, and that most internal + constructors don't require new (and some, like String, break when + you use it), it just seems superfluous and distracting. + --Kris + == Testing/Optimization == TODO: Add some information here about testing/validation/etc. diff --git a/common/content/hints.js b/common/content/hints.js index cdc90dfb..5ae1e892 100644 --- a/common/content/hints.js +++ b/common/content/hints.js @@ -86,13 +86,7 @@ function Hints() //{{{ // Used to open multiple hints function hintSequenceElement(elem) { - // Want to always open sequence hints in background - // (remember: NEW_BACKGROUND_TAB and NEW_TAB semantics assume - // that loadInBackground=true) - if (options.getPref("browser.tabs.loadInBackground")) - buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB); - else - buffer.followLink(elem, liberator.NEW_TAB); + buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB); // Move to next element in sequence // TODO: Maybe we find a *simple* way to keep the hints displayed rather than