Fix some option validators. Add tests.

common/tests/functional/testOptions.js

@@ -0,0 +1,40 @@
+// Runs a slew of generic option tests
+
+var utils = require("utils");
+const { module } = utils;
+
+var dactyllib = module("dactyl");
+var jumlib = module("resource://mozmill/modules/jum.js");
+
+var setupModule = function (module) {
+    controller = mozmill.getBrowserController();
+    dactyl = new dactyllib.Controller(controller);
+};
+var teardownModule = function (module) {
+    dactyl.teardown();
+}
+
+function $(selector) controller.window.document.querySelector(selector);
+
+function testDefaultValidators() {
+    for (var option in dactyl.modules.options)
+        dactyl.assertNoErrors(function () {
+            dactyl.assertNoErrorMessages(function () {
+                dump("OPT VAL " + option.name + "\n");
+                utils.assert("testOptions.testValidators", option.validator(option.value),
+                             "Option '" + option.name + "' validator failed");
+            });
+        });
+}
+
+var options = {};
+
+function testCompleters() {
+    for (var option in dactyl.modules.options)
+        for (var [,value] in Iterator([""].concat(options[option.name] || []))) {
+            dump("OPT COMP " + option.name + " " + value + "\n");
+            dactyl.testCompleter(option, "completer", value, "Option '" + option.name + "' completer failed");
+        }
+}
+
+// vim: sw=4 ts=8 et: