1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 15:47:58 +01:00

Allow canceling of asynchronous completions. Some other small completion cleanups. NOTE to myself: The completion/commandline code is quite spaghetti code again, need to reduce unused functions, and reduce side effects inside functions like resetCompletions

This commit is contained in:
Martin Stubenschrott
2009-01-05 23:56:09 +01:00
parent 54bc277231
commit 2b404b74a0
4 changed files with 22 additions and 5 deletions

View File

@@ -936,6 +936,7 @@ function CommandLine() //{{{
if (history)
history.save();
this.resetCompletions(); // cancels any asynchronous completion still going on, must be before completions = null
completions = null;
history = null;
@@ -1075,7 +1076,7 @@ function CommandLine() //{{{
}
else if (event.type == "input")
{
this.resetCompletions();
//this.resetCompletions(); -> already handled by "keypress" below (hopefully), so don't do it twice
liberator.triggerCallback("change", currentExtendedMode, command);
}
else if (event.type == "keypress")
@@ -1432,8 +1433,15 @@ function CommandLine() //{{{
resetCompletions: function resetCompletions()
{
autocompleteTimer.reset();
// liberator.dump("Resetting completions...");
if (completions)
{
// if any child context has a cancelFunc, call it
for (let [, context] in Iterator(completions.context.top.contexts))
if (context.cancelFunc)
context.cancelFunc();
completions.wildIndex = -1;
completions.previewClear();
}