From 31d846c0f3df8901f74a772f2f6f933d44ed0b06 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Tue, 11 Jan 2011 12:04:00 -0500 Subject: [PATCH] Fix base.jsm:deprecated with null filenames. Closes issue #261. --- common/modules/base.jsm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/modules/base.jsm b/common/modules/base.jsm index c30c734a..c198b2b2 100644 --- a/common/modules/base.jsm +++ b/common/modules/base.jsm @@ -272,10 +272,10 @@ function deprecated(reason, fn) { let obj = this.className ? this.className + "#" : this.constructor.className ? this.constructor.className + "#" : ""; - let filename = frame.filename.replace(/.* -> /, ""); + let filename = (frame.filename || "unknown").replace(/.* -> /, ""); if (!set.add(deprecatedMethod.seen, filename)) util.dactyl(fn).echoerr( - util.urlPath(filename || "unknown") + ":" + frame.lineNumber + ": " + + util.urlPath(filename) + ":" + frame.lineNumber + ": " + obj + (fn.name || name) + " is deprecated: " + reason); return func.apply(this, arguments); }