gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-02-16 23:15:47 +01:00
Code Issues Projects Releases Wiki Activity

Make Bookmark objects live writeable.

Browse Source
This commit is contained in:
Kris Maglione
2010-12-10 01:38:39 -05:00
parent 38c2d07ef1
commit 36205c6c0e
7 changed files with 57 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
common/content/bookmarks.js
View File

@@ -57,11 +57,10 @@ const Bookmarks = Module("bookmarks", {
try {
let uri = util.createURI(url);
if (!force && this.isBookmarked(uri.spec))
for (let bmark in bookmarkcache)
for (var bmark in bookmarkcache)
if (bmark.url == uri.spec) {
var id = bmark.id;
if (title)
services.bookmarks.setItemTitle(id, title);
bmark.title = title;
break;
}
@@ -69,17 +68,18 @@ const Bookmarks = Module("bookmarks", {
PlacesUtils.tagging.untagURI(uri, null);
PlacesUtils.tagging.tagURI(uri, tags);
}
if (id == undefined)
id = services.bookmarks.insertBookmark(
if (bmark == undefined)
bmark = bookmarkcache.bookmarks[
services.bookmarks.insertBookmark(
services.bookmarks[unfiled ? "unfiledBookmarksFolder" : "bookmarksMenuFolder"],
uri, -1, title || url);
if (!id)
uri, -1, title || url)];
if (!bmark)
return false;
if (post !== undefined)
PlacesUtils.setPostDataForBookmark(id, post);
bmark.post = post;
if (keyword)
services.bookmarks.setKeywordForBookmark(id, keyword);
bmark.keyword = keyword;
}
catch (e) {
dactyl.log(e, 0);

5
common/content/completion.js
View File

@@ -527,9 +527,8 @@ const CompletionContext = Class("CompletionContext", {
// A simple binary search to find the longest substring
// of the given string which also matches the current
// item's text.
var m, len = substring.length;
var n = substring.length;
var i = 0;
let len = substring.length;
let i = 0, m, n = len;
while (n) {
m = Math.floor(n / 2);
let keep = compare(fixCase(item.text), substring.substring(0, i + m));