From 46673bfc7607d0596feddea6e5cb4784badbab86 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Mon, 20 Sep 2010 12:23:29 -0400 Subject: [PATCH] Fix revision ddb9e0d895c3. :bmark! was right, was wrong. --- common/content/bookmarks.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/common/content/bookmarks.js b/common/content/bookmarks.js index 5665a9ee..23bb9eb3 100644 --- a/common/content/bookmarks.js +++ b/common/content/bookmarks.js @@ -34,11 +34,10 @@ const Bookmarks = Module("bookmarks", { add: function add(starOnly, title, url, keyword, tags, force) { try { let uri = util.createURI(url); - if (force && bookmarks.isBookmarked(uri.spec)) - // WTF? This seems wrong... --Kris + if (!force && bookmarks.isBookmarked(uri.spec)) for (let bmark in bookmarkcache) - if (bmark[0] == uri.spec) { - var id = bmark[5]; + if (bmark.url == uri.spec) { + var id = bmark.id; if (title) services.get("bookmarks").setItemTitle(id, title); break; @@ -423,7 +422,7 @@ const Bookmarks = Module("bookmarks", { } commandline.open(":", - commands.commandToString({ command: "bmark", options: options, arguments: [buffer.URL], bang: bmarks.length == 1 }), + commands.commandToString({ command: "bmark", options: options, arguments: [buffer.URL] }), modes.EX); });