gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-23 16:12:26 +01:00
Code Issues Projects Releases Wiki Activity

don't iterate over the liberator.config.helpFiles array using a for...in loop

Browse Source
This commit is contained in:
Doug Kearns
2008-08-13 05:21:46 +00:00
parent 7c0280308b
commit 4815e074a3
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
content/liberator.js
View File

@@ -380,23 +380,23 @@ const liberator = (function () //{{{
var files = liberator.config.helpFiles; var files = liberator.config.helpFiles;
var res = []; var res = [];
for (var file in files) for (var i = 0; i < files.length; i++)
{ {
try try
{ {
var xmlhttp = new XMLHttpRequest(); var xmlhttp = new XMLHttpRequest();
xmlhttp.open("GET", "chrome://" + liberator.config.name.toLowerCase() + "/locale/" + files[file], false); xmlhttp.open("GET", "chrome://" + liberator.config.name.toLowerCase() + "/locale/" + files[i], false);
xmlhttp.send(null); xmlhttp.send(null);
} }
catch (e) catch (e)
{ {
liberator.log("Error opening chrome://" + liberator.config.name.toLowerCase() + "/locale/" + files[file], 1); liberator.log("Error opening chrome://" + liberator.config.name.toLowerCase() + "/locale/" + files[i], 1);
continue; continue;
} }
var doc = xmlhttp.responseXML; var doc = xmlhttp.responseXML;
var elems = doc.getElementsByClassName("tag"); var elems = doc.getElementsByClassName("tag");
for (var i = 0; i < elems.length; i++) for (var j = 0; j < elems.length; j++)
res.push([elems[i].textContent, files[file]]); res.push([elems[j].textContent, files[i]]);
} }
return [0, liberator.completion.filter(res, filter)]; return [0, liberator.completion.filter(res, filter)];