gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-01-05 00:14:11 +01:00
Code Issues Projects Releases Wiki Activity

Remove unnecessary use of values() when iterating over arrays.

Browse Source
This commit is contained in:
Doug Kearns
2015-05-11 23:56:31 +10:00
parent a8e70d3f43
commit 48acf656ec
27 changed files with 81 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
common/modules/commands.jsm
View File

@@ -576,7 +576,7 @@ var CommandHive = Class("CommandHive", Contexts.Hive, {
_("command.wontReplace", name));
}
for (let name of values(names)) {
for (let name of names) {
ex.__defineGetter__(name, function () this._run(name));
if (name in this._map && !this._map[name].isPlaceholder)
this.remove(name);
@@ -587,7 +587,7 @@ var CommandHive = Class("CommandHive", Contexts.Hive, {
memoize(this._map, name, () => commands.Command(specs, description, action, extra));
if (!extra.hidden)
memoize(this._list, this._list.length, closure);
for (let alias of values(names.slice(1)))
for (let alias of names.slice(1))
memoize(this._map, alias, closure);
return name;
@@ -647,7 +647,7 @@ var CommandHive = Class("CommandHive", Contexts.Hive, {
let cmd = this.get(name);
this._list = this._list.filter(c => c !== cmd);
for (let name of values(cmd.names))
for (let name of cmd.names)
delete this._map[name];
}
});