gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-03-13 06:45:48 +01:00
Code Issues Projects Releases Wiki Activity

Implement some cleanup code for groups.

Browse Source 
--HG--
branch : groups
This commit is contained in:
Kris Maglione
2011-02-05 05:39:40 -05:00
parent 60059bcbc3
commit 5429db5c53
1 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
common/content/contexts.js
View File

@@ -11,6 +11,13 @@ var Group = Class("Group", {
this.description = description; this.description = description;
this.filter = filter || function (uri) true; this.filter = filter || function (uri) true;
this.persist = persist || false; this.persist = persist || false;
this.subGroups = [];
},
cleanup: function cleanup() {
for (let subGroup in values(this.subGroups))
if (subGroup.cleanup)
subGroup.cleanup();
}, },
get toStringParams() [this.name], get toStringParams() [this.name],
@@ -37,7 +44,11 @@ var Group = Class("Group", {
this.Group = constructor; this.Group = constructor;
this.name = name; this.name = name;
memoize(Group.prototype, name, function () constructor(this)); memoize(Group.prototype, name, function () {
let group = constructor(this);
this.subGroups.push(group);
return group;
});
memoize(Group.subGroupMap, name, memoize(Group.subGroupMap, name,
function () Object.create(Object.create(contexts.subGroupProto, function () Object.create(Object.create(contexts.subGroupProto,
@@ -89,11 +100,20 @@ var Contexts = Module("contexts", {
}, },
removeGroup: function removeGroup(name, filter) { removeGroup: function removeGroup(name, filter) {
if (isObject(name)) {
if (this.groupList.indexOf(name) === -1)
return;
name = name.name;
}
let group = this.getGroup(name); let group = this.getGroup(name);
dactyl.assert(!group || !group.builtin, "Cannot remove builtin group"); dactyl.assert(!group || !group.builtin, "Cannot remove builtin group");
if (group) if (group) {
this.groupList.splice(this.groupList.indexOf(group), 1); this.groupList.splice(this.groupList.indexOf(group), 1);
group.cleanup();
}
if (this.context && this.context.group === group) if (this.context && this.context.group === group)
this.context.group = null; this.context.group = null;
@@ -180,6 +200,7 @@ var Contexts = Module("contexts", {
delete plugins[this.NAME]; delete plugins[this.NAME];
if (plugins[this.PATH] === this) if (plugins[this.PATH] === this)
delete plugins[this.PATH]; delete plugins[this.PATH];
contexts.removeGroup(this.GROUP);
}) })
}); });
Class.replaceProperty(plugins, file.path, self); Class.replaceProperty(plugins, file.path, self);
@@ -189,8 +210,7 @@ var Contexts = Module("contexts", {
Object.defineProperty(plugins, self.NAME, { Object.defineProperty(plugins, self.NAME, {
configurable: true, configurable: true,
enumerable: true, enumerable: true,
value: self, value: self
writeable: false
}); });
} }