gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 04:27:59 +01:00
Code Issues Projects Releases Wiki Activity

Fix some cleanup issues. Better error pages for bad dactyl: URLs. Remove some dead code. Other cleanup.

Browse Source
This commit is contained in:
Kris Maglione
2011-08-21 10:41:46 -04:00
parent ffe138b4e3
commit 5f42595f65
13 changed files with 99 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
common/tests/functional/testHelpCommands.js
View File

@@ -21,10 +21,17 @@ var setupTest = function (test) {
function urlTarget(url) Services.io.newChannel(url, null, null).name;
__defineGetter__("doesNotExist", function () {
delete this.doesNotExist;
return this.doesNotExist = urlTarget("dactyl://help-tag/non-existent-help-tag-url-thingy");
});
function urlExists(url) {
try {
let chan = Services.io.newChannel(url);
chan.open();
try { chan.cancel(Cr.NS_BINDING_ABORTED) } catch (e) {}
return true;
}
catch (e) {
return false;
}
}
const HELP_FILES = ["all", "tutorial", "intro", "starting", "browsing",
"buffer", "cmdline", "editing", "options", "pattern", "tabs", "hints",
@@ -70,7 +77,7 @@ var testExHelpCommand_PageTagArg_OpensHelpPageContainingTag = function () {
let links = controller.tabs.activeTab.querySelectorAll("a[href^='dactyl:']");
let missing = Array.filter(links, function (link) urlTarget(link.href) === doesNotExist)
let missing = Array.filter(links, function (link) urlExists(link.href))
.map(function (link) link.textContent + " -> " + link.href);
utils.assertEqual("testHelpCommands.assertNoDeadLinks", 0, missing.length,