From 60a2f83daab8a035b83b3bde7b97ff1160f876f2 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Tue, 28 Sep 2010 09:42:59 -0400 Subject: [PATCH] Fix beeping after every command when command after-image isn't disabled. --- common/content/commandline.js | 4 ++-- common/content/dactyl.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/common/content/commandline.js b/common/content/commandline.js index e6b25fea..79f9edb2 100644 --- a/common/content/commandline.js +++ b/common/content/commandline.js @@ -555,12 +555,12 @@ const CommandLine = Module("commandline", { }, get command() { - if (this.widgets.command) + if (this.commandVisible && this.widgets.command) return this._lastCommand = this.widgets.command[1]; return this._lastCommand; }, set command(val) { - if (this.widgets.command) + if (this.commandVisible) return this.widgets.command = val; return this._lastCommand = val; }, diff --git a/common/content/dactyl.js b/common/content/dactyl.js index 57836873..412346ed 100644 --- a/common/content/dactyl.js +++ b/common/content/dactyl.js @@ -124,6 +124,7 @@ const Dactyl = Module("dactyl", { * 'visualbell' option. */ beep: requiresMainThread(function () { + dactyl.dumpStack(); // FIXME: popups clear the command line if (options["visualbell"]) { // flash the visual bell