After some profiling, give all modules a common prototype.

2025-12-30 08:52:27 +01:00 · 2011-08-22 01:45:41 -04:00
parent fbb6af43ed
commit 60c858b59b
21 changed files with 33 additions and 55 deletions
--- a/common/modules/addons.jsm
+++ b/common/modules/addons.jsm
@@ -10,8 +10,7 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("addons", {
    exports: ["AddonManager", "Addons", "Addon", "addons"],
-    require: ["services"],
-    use: ["completion", "config", "io", "messages", "prefs", "template", "util"]
+    require: ["services"]
 }, this);

 var callResult = function callResult(method) {
--- a/common/modules/base.jsm
+++ b/common/modules/base.jsm
@@ -122,6 +122,7 @@ if (!Object.keys)

 let getGlobalForObject = Cu.getGlobalForObject || function (obj) obj.__parent__;

+let jsmodules = {};
 let use = {};
 let loaded = {};
 let currentModule;
@@ -132,18 +133,15 @@ function defineModule(name, params, module) {

    module.NAME = name;
    module.EXPORTED_SYMBOLS = params.exports || [];
+    delete module.File;
+
    defineModule.loadLog.push("[Begin " + name + "]");
    defineModule.prefix += "  ";
-    for (let [, mod] in Iterator(params.require || []))
-        require(module, mod);

-    for (let [, mod] in Iterator(params.use || []))
-        if (loaded.hasOwnProperty(mod))
-            require(module, mod, "use");
-        else {
-            use[mod] = use[mod] || [];
-            use[mod].push(module);
-        }
+    for (let [, mod] in Iterator(params.require || []))
+        require(jsmodules, mod, null, name);
+    module.__proto__ = jsmodules;
+
    module._lastModule = currentModule;
    currentModule = module;
    module.startTime = Date.now();
@@ -189,14 +187,12 @@ function endModule() {
    defineModule.prefix = defineModule.prefix.slice(0, -2);
    defineModule.loadLog.push("(End   " + currentModule.NAME + ")");

-    for (let [, mod] in Iterator(use[currentModule.NAME] || []))
-        require(mod, currentModule.NAME, "use");
-
    loaded[currentModule.NAME] = 1;
+    require(jsmodules, currentModule.NAME);
    currentModule = currentModule._lastModule;
 }

-function require(obj, name, from) {
+function require(obj, name, from, targetName) {
    try {
        if (arguments.length === 1)
            [obj, name] = [{}, obj];
@@ -204,7 +200,8 @@ function require(obj, name, from) {
        let caller = Components.stack.caller;

        if (!loaded[name])
-            defineModule.loadLog.push((from || "require") + ": loading " + name + " into " + (obj.NAME || caller.filename + ":" + caller.lineNumber));
+            defineModule.loadLog.push((from || "require") + ": loading " + name +
+                                      " into " + (targetName || obj.NAME || caller.filename + ":" + caller.lineNumber));

        JSMLoader.load(name + ".jsm", obj);
        return obj;
@@ -228,8 +225,7 @@ defineModule("base", {
        "isGenerator", "isinstance", "isObject", "isString", "isSubclass", "iter", "iterAll",
        "iterOwnProperties", "keys", "memoize", "octal", "properties", "require", "set", "update",
        "values", "withCallerGlobal"
-    ],
-    use: ["config", "services", "util"]
+    ]
 }, this);

 function Runnable(self, func, args) {
--- a/common/modules/commands.jsm
+++ b/common/modules/commands.jsm
@@ -11,8 +11,7 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("commands", {
    exports: ["ArgType", "Command", "Commands", "CommandOption", "Ex", "commands"],
-    require: ["contexts", "messages", "util"],
-    use: ["config", "help", "options", "services", "template"]
+    require: ["contexts", "messages", "util"]
 }, this);

 /**
--- a/common/modules/completion.jsm
+++ b/common/modules/completion.jsm
@@ -10,8 +10,7 @@ try {

 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("completion", {
-    exports: ["CompletionContext", "Completion", "completion"],
-    use: ["config", "messages", "template", "util"]
+    exports: ["CompletionContext", "Completion", "completion"]
 }, this);

 /**
--- a/common/modules/config.jsm
+++ b/common/modules/config.jsm
@@ -10,8 +10,7 @@ let global = this;
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("config", {
    exports: ["ConfigBase", "Config", "config"],
-    require: ["dom", "protocol", "services", "storage", "util", "template"],
-    use: ["io", "messages", "prefs", "styles"]
+    require: ["dom", "protocol", "services", "storage", "util", "template"]
 }, this);

 function AboutHandler() {}
--- a/common/modules/contexts.jsm
+++ b/common/modules/contexts.jsm
@@ -8,8 +8,7 @@ try {

 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("contexts", {
-    exports: ["Contexts", "Group", "contexts"],
-    use: ["commands", "messages", "options", "services", "storage", "styles", "template", "util"]
+    exports: ["Contexts", "Group", "contexts"]
 }, this);

 var Const = function Const(val) Class.Property({ enumerable: true, value: val });
--- a/common/modules/dom.jsm
+++ b/common/modules/dom.jsm
@@ -7,8 +7,7 @@

 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("dom", {
-    exports: ["$", "DOM", "NS", "XBL", "XHTML", "XUL"],
-    use: ["config", "highlight", "template", "util"],
+    exports: ["$", "DOM", "NS", "XBL", "XHTML", "XUL"]
 }, this);

 var XBL = Namespace("xbl", "http://www.mozilla.org/xbl");
--- a/common/modules/downloads.jsm
+++ b/common/modules/downloads.jsm
@@ -6,8 +6,7 @@

 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("downloads", {
-    exports: ["Download", "Downloads", "downloads"],
-    use: ["io", "messages", "prefs", "services", "util"]
+    exports: ["Download", "Downloads", "downloads"]
 }, this);

 Cu.import("resource://gre/modules/DownloadUtils.jsm", this);
--- a/common/modules/finder.jsm
+++ b/common/modules/finder.jsm
@@ -7,8 +7,7 @@
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("finder", {
    exports: ["RangeFind", "RangeFinder", "rangefinder"],
-    require: ["prefs"],
-    use: ["dom", "messages", "services", "util"]
+    require: ["prefs"]
 }, this);

 function equals(a, b) XPCNativeWrapper(a) == XPCNativeWrapper(b);
--- a/common/modules/help.jsm
+++ b/common/modules/help.jsm
@@ -7,8 +7,7 @@
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("help", {
    exports: ["help"],
-    require: ["dom", "protocol", "services", "util"],
-    use: ["config", "highlight", "messages", "template"]
+    require: ["dom", "protocol", "services", "util"]
 }, this);

 var Help = Module("Help", {
--- a/common/modules/highlight.jsm
+++ b/common/modules/highlight.jsm
@@ -7,8 +7,7 @@
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("highlight", {
    exports: ["Highlight", "Highlights", "highlight"],
-    require: ["services", "styles", "util"],
-    use: ["messages", "template"]
+    require: ["services", "styles", "util"]
 }, this);

 var Highlight = Struct("class", "selector", "sites",
--- a/common/modules/io.jsm
+++ b/common/modules/io.jsm
@@ -12,8 +12,7 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("io", {
    exports: ["IO", "io"],
-    require: ["services"],
-    use: ["config", "help", "messages", "storage", "styles", "template", "util"]
+    require: ["services"]
 }, this);

 // TODO: why are we passing around strings rather than file objects?
--- a/common/modules/javascript.jsm
+++ b/common/modules/javascript.jsm
@@ -10,8 +10,7 @@ try {

 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("javascript", {
-    exports: ["JavaScript", "javascript"],
-    use: ["messages", "services", "template", "util"]
+    exports: ["JavaScript", "javascript"]
 }, this);

 let isPrototypeOf = Object.prototype.isPrototypeOf;
--- a/common/modules/options.jsm
+++ b/common/modules/options.jsm
@@ -11,8 +11,7 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("options", {
    exports: ["Option", "Options", "ValueError", "options"],
-    require: ["contexts", "messages", "storage"],
-    use: ["commands", "completion", "config", "prefs", "services", "styles", "template", "util"]
+    require: ["contexts", "messages", "storage"]
 }, this);

 /** @scope modules */
--- a/common/modules/prefs.jsm
+++ b/common/modules/prefs.jsm
@@ -11,8 +11,7 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("prefs", {
    exports: ["Prefs", "localPrefs", "prefs"],
-    require: ["services", "util"],
-    use: ["config", "messages", "template"]
+    require: ["services", "util"]
 }, this);

 var Prefs = Module("prefs", XPCOM([Ci.nsIObserver, Ci.nsISupportsWeakReference]), {
--- a/common/modules/sanitizer.jsm
+++ b/common/modules/sanitizer.jsm
@@ -17,7 +17,6 @@ try {
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("sanitizer", {
    exports: ["Range", "Sanitizer", "sanitizer"],
-    use: ["config"],
    require: ["messages", "prefs", "services", "storage", "template", "util"]
 }, this);

--- a/common/modules/services.jsm
+++ b/common/modules/services.jsm
@@ -9,8 +9,7 @@ try {
 var global = this;
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("services", {
-    exports: ["services"],
-    use: ["util"]
+    exports: ["services"]
 }, this);

 /**
--- a/common/modules/storage.jsm
+++ b/common/modules/storage.jsm
@@ -293,7 +293,7 @@ var Storage = Module("Storage", {
 * @param {boolean} checkPWD Whether to allow expansion relative to the
 *          current directory. @default true
 */
-var File = Class("File", {
+this.File = Class("File", {
    init: function (path, checkPWD) {
        let file = services.File();

@@ -621,6 +621,6 @@ var File = Class("File", {

 endModule();

-// catch(e){dump(e.fileName+":"+e.lineNumber+": "+e+"\n" + e.stack);}
+// catch(e){ dump(e + "\n" + (e.stack || Error().stack)); Components.utils.reportError(e) }

 // vim: set fdm=marker sw=4 sts=4 et ft=javascript:
--- a/common/modules/styles.jsm
+++ b/common/modules/styles.jsm
@@ -7,8 +7,7 @@
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("styles", {
    exports: ["Style", "Styles", "styles"],
-    require: ["services", "util"],
-    use: ["contexts", "dom", "messages", "template"]
+    require: ["services", "util"]
 }, this);

 function cssUri(css) "chrome-data:text/css," + encodeURI(css);
--- a/common/modules/template.jsm
+++ b/common/modules/template.jsm
@@ -7,8 +7,7 @@
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("template", {
    exports: ["Binding", "Template", "template"],
-    require: ["util"],
-    use: ["help", "messages", "services"]
+    require: ["util"]
 }, this);

 default xml namespace = XHTML;
--- a/common/modules/util.jsm
+++ b/common/modules/util.jsm
@@ -8,11 +8,11 @@

 try {

+    let global=this;
 Components.utils.import("resource://dactyl/bootstrap.jsm");
 defineModule("util", {
    exports: ["DOM", "$", "FailedAssertion", "Math", "NS", "Point", "Util", "XBL", "XHTML", "XUL", "util"],
-    require: ["dom", "services"],
-    use: ["commands", "config", "highlight", "messages", "overlay", "storage", "template"]
+    require: ["dom", "services"]
 }, this);

 var FailedAssertion = Class("FailedAssertion", ErrorBase, {