From 667b1f783a5b22ce949f5575ee24091c8907aea4 Mon Sep 17 00:00:00 2001 From: Doug Kearns Date: Mon, 27 Aug 2007 11:44:03 +0000 Subject: [PATCH] use the coerced boolean value of args rather than testing for 0 string length when determining if an arg was passed to an ex command --- chrome/content/vimperator/commands.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/chrome/content/vimperator/commands.js b/chrome/content/vimperator/commands.js index 9245eac0..62bddeac 100644 --- a/chrome/content/vimperator/commands.js +++ b/chrome/content/vimperator/commands.js @@ -623,7 +623,7 @@ function Commands() //{{{ addDefaultCommand(new Command(["mapc[lear]"], function(args) { - if (args.length > 0) + if (args) { vimperator.echoerr("E474: Invalid argument"); return; @@ -667,7 +667,7 @@ function Commands() //{{{ function(args) { // ignore invalid mark characters unless there are no valid mark chars - if (args.length > 0 && !/[a-zA-Z]/.test(args)) + if (args && !/[a-zA-Z]/.test(args)) { vimperator.echoerr("E283: No marks matching \"" + args + "\""); return; @@ -756,8 +756,10 @@ function Commands() //{{{ addDefaultCommand(new Command(["o[pen]", "e[dit]"], function(args, special) { - if (args.length > 0) + if (args) + { vimperator.open(args); + } else { if (special) @@ -838,7 +840,7 @@ function Commands() //{{{ function(args) { // ignore invalid mark characters unless there are no valid mark chars - if (args.length > 0 && !/[a-zA-Z0-9]/.test(args)) + if (args && !/[a-zA-Z0-9]/.test(args)) { vimperator.echoerr("E283: No QuickMarks matching \"" + args + "\""); return; @@ -1143,7 +1145,7 @@ function Commands() //{{{ if (/\btabopen\b/.test(vimperator.options["activate"])) where = special ? vimperator.NEW_BACKGROUND_TAB : vimperator.NEW_TAB; - if (args.length > 0) + if (args) vimperator.open(args, where); else vimperator.open("about:blank", where);