gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-01-31 17:35:46 +01:00
Code Issues Projects Releases Wiki Activity

Clone arrays assigned to "live" properties, partially to deal with issues with horrid Sandbox proxies and partly for other somewhat obvious reasons.

Browse Source
This commit is contained in:
Kris Maglione
2011-02-04 15:56:23 -05:00
parent e514899d23
commit 6a3d5dcfce
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
common/modules/highlight.jsm
View File

@@ -18,8 +18,14 @@ var Highlight = Struct("class", "selector", "sites",
Highlight.liveProperty = function (name, prop) { Highlight.liveProperty = function (name, prop) {
this.prototype.__defineGetter__(name, function () this.get(name)); this.prototype.__defineGetter__(name, function () this.get(name));
this.prototype.__defineSetter__(name, function (val) { this.prototype.__defineSetter__(name, function (val) {
if (isObject(val) && name !== "style" && Object.freeze) if (isObject(val) && name !== "style") {
Object.freeze(val); if (isArray(val))
val = Array.slice(val);
else
val = update({}, val);
if (Object.freeze)
Object.freeze(val);
}
this.set(name, val); this.set(name, val);
if (name === "value" || name === "extends") if (name === "value" || name === "extends")

2
common/modules/styles.jsm
View File

@@ -21,6 +21,8 @@ Sheet.liveProperty = function (name) {
let i = this.prototype.members[name]; let i = this.prototype.members[name];
this.prototype.__defineGetter__(name, function () this[i]); this.prototype.__defineGetter__(name, function () this[i]);
this.prototype.__defineSetter__(name, function (val) { this.prototype.__defineSetter__(name, function (val) {
if (isArray(val))
val = Array.slice(val);
if (isArray(val) && Object.freeze) if (isArray(val) && Object.freeze)
Object.freeze(val); Object.freeze(val);
this[i] = val; this[i] = val;

2
common/modules/util.jsm
View File

@@ -1672,7 +1672,7 @@ var Util = Module("Util", XPCOM([Ci.nsIObserver, Ci.nsISupportsWeakReference]),
if (nodes && node.@key) if (nodes && node.@key)
nodes[node.@key] = domnode; nodes[node.@key] = domnode;
if (node.@highlight) if ("@highlight" in node)
highlight.highlightNode(domnode, String(node.@highlight), nodes || true); highlight.highlightNode(domnode, String(node.@highlight), nodes || true);
return domnode; return domnode;
default: default: