1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-03-02 08:15:46 +01:00

Replace expression closures (getters).

Expression closures are to be axed. See https://bugzil.la/1083458.
This commit is contained in:
Doug Kearns
2015-05-27 04:42:30 +10:00
parent ce82387cdd
commit 6e8040286a
48 changed files with 808 additions and 532 deletions

View File

@@ -68,24 +68,29 @@ var Download = Class("Download", {
return this;
},
get active() !this.stopped,
get active() { return !this.stopped; },
get targetFile() File(this.download.target.path),
get targetFile() { return File(this.download.target.path); },
get displayName() this.targetFile.leafName,
get displayName() { return this.targetFile.leafName; },
get status() states[this.state],
get status() { return states[this.state]; },
inState: function inState(states) states.indexOf(this.status) >= 0,
allowedCommands: Class.Memoize(function () {
let self = this;
return {
get delete() !self.active && (self.targetFile.exists() || self.hasPartialData),
get launch() self.targetFile.exists() && self.succeeded,
get stop() self.active,
get remove() !self.active,
get resume() self.canceled
get delete() {
return !self.active &&
(self.targetFile.exists() || self.hasPartialData);
},
get launch() {
return self.targetFile.exists() && self.succeeded;
},
get stop() { return self.active; },
get remove() { return !self.active; },
get resume() { return self.canceled; }
};
}),
@@ -318,7 +323,9 @@ var DownloadList = Class("DownloadList",
allowedCommands: Class.Memoize(function () {
let self = this;
return {
get clear() iter(self.downloads.values()).some(dl => dl.allowedCommands.remove)
get clear() {
return iter(self.downloads.values()).some(dl => dl.allowedCommands.remove);
}
};
}),
@@ -482,7 +489,9 @@ var Downloads_ = Module("downloads", XPCOM(Ci.nsIDownloadProgressListener), {
names: ["-sort", "-s"],
description: "Sort order (see 'downloadsort')",
type: CommandOption.LIST,
get default() modules.options["downloadsort"],
get default() {
return modules.options["downloadsort"];
},
completer: function (context, args) modules.options.get("downloadsort").completer(context, { values: args["-sort"] }),
validator: function (value) modules.options.get("downloadsort").validator(value)
}