From 70c82c0f193a40dd84201f7b067f1a12c489ec68 Mon Sep 17 00:00:00 2001 From: Doug Kearns Date: Mon, 15 Dec 2008 21:50:04 +1100 Subject: [PATCH] address Kris's double barrelled blasphemy --- vimperator/content/bookmarks.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vimperator/content/bookmarks.js b/vimperator/content/bookmarks.js index 5ae08f99..21f73662 100644 --- a/vimperator/content/bookmarks.js +++ b/vimperator/content/bookmarks.js @@ -604,6 +604,10 @@ function Bookmarks() //{{{ { // FIXME: returning here doesn't make sense // Why the hell doesn't it make sense? --Kris + // Because it unconditionally bypasses the final error message + // block and does so only when listing items, not opening them. In + // short it breaks the :bmarks command which doesn't make much + // sense to me but I'm old-fashioned. --djk if (!openItems) return completion.listCompleter("bookmark", filter, maxItems, tags); let items = completion.runCompleter("bookmark", filter, maxItems, tags); @@ -852,6 +856,7 @@ function History() //{{{ { // FIXME: returning here doesn't make sense // Why the hell doesn't it make sense? --Kris + // See comment at bookmarks.list --djk if (!openItems) return completion.listCompleter("history", filter, maxItems); let items = completion.runCompleter("history", filter, maxItems);