gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-23 22:22:27 +01:00
Code Issues Projects Releases Wiki Activity

Don't beep when jumping too far with :back/:forward.

Browse Source 
Specifying a count larger than the number of history items shouldn't
cause :back and :forward (H and L) to beep. This is also consistent with
other commands.
This commit is contained in:
Doug Kearns
2009-05-20 23:02:42 +10:00
parent 3df0e174ac
commit 72aba0f876
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
vimperator/content/bookmarks.js
View File

@@ -830,14 +830,20 @@ function History() //{{{
return items; return items;
}, },
// TODO: better names and move to buffer.? // TODO: better names
stepTo: function stepTo(steps) stepTo: function stepTo(steps)
{ {
let index = window.getWebNavigation().sessionHistory.index + steps; let start = 0;
if (index >= 0 && index < window.getWebNavigation().sessionHistory.count) let end = window.getWebNavigation().sessionHistory.count - 1;
window.getWebNavigation().gotoIndex(index); let current = window.getWebNavigation().sessionHistory.index;
if (current == start && steps < 0 || current == end && steps > 0)
liberator.beep();
else else
liberator.beep(); // XXX: really wanted? {
let index = Math.max(start, Math.min(end, current + steps));
window.getWebNavigation().gotoIndex(index);
}
}, },
goToStart: function goToStart() goToStart: function goToStart()
@@ -847,7 +853,7 @@ function History() //{{{
if (index > 0) if (index > 0)
window.getWebNavigation().gotoIndex(0); window.getWebNavigation().gotoIndex(0);
else else
liberator.beep(); // XXX: really wanted? liberator.beep();
}, },
@@ -859,7 +865,7 @@ function History() //{{{
if (sh.index < max) if (sh.index < max)
window.getWebNavigation().gotoIndex(max); window.getWebNavigation().gotoIndex(max);
else else
liberator.beep(); // XXX: really wanted? liberator.beep();
}, },