1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 09:48:00 +01:00

Fix commands.removeUserCommand.

This commit is contained in:
Kris Maglione
2010-09-17 06:52:15 -04:00
parent 0a0bd45601
commit 7d0c99d0e1

View File

@@ -347,7 +347,7 @@ const Commands = Module("commands", {
if (!replace && args[3] && args[3].user) if (!replace && args[3] && args[3].user)
dactyl.assert(!names.some(function (name) name in this._exMap, this), dactyl.assert(!names.some(function (name) name in this._exMap, this),
"Not replacing command " + args[0]); "Not replacing command " + args[0]);
for (let name in names) for (let name in values(names))
if (name in this._exMap) if (name in this._exMap)
commands.removeUserCommand(name); commands.removeUserCommand(name);
@@ -833,7 +833,7 @@ const Commands = Module("commands", {
removeUserCommand: function (name) { removeUserCommand: function (name) {
let cmd = this.get(name); let cmd = this.get(name);
dactyl.assert(cmd.user, "E184: No such user-defined command: " + name); dactyl.assert(cmd.user, "E184: No such user-defined command: " + name);
for (let name in values(cmd.names)) for (let name in array.itervalues(cmd.names))
delete this._exMap[name]; delete this._exMap[name];
this._exCommands = this._exCommands.filter(function (c) c != cmd); this._exCommands = this._exCommands.filter(function (c) c != cmd);
}, },
@@ -1133,7 +1133,8 @@ const Commands = Module("commands", {
}); });
}, },
javascript: function () { javascript: function () {
JavaScript.setCompleter(this.get, [function () ([c.name, c.description] for (c in commands))]); JavaScript.setCompleter([this.get, this.removeUserCommand],
[function () ([c.name, c.description] for (c in commands))]);
}, },
mappings: function () { mappings: function () {
mappings.add(config.browserModes, mappings.add(config.browserModes,