gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 23:47:58 +01:00
Code Issues Projects Releases Wiki Activity

Remove some old/invalid FIXME comments.

Browse Source
This commit is contained in:
Doug Kearns
2009-05-13 01:34:09 +10:00
parent 32fc0f97c2
commit 7fc37fe79c
5 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/content/buffer.js
View File

@@ -1931,7 +1931,7 @@ function Marks() //{{{
} }
if (!ok) if (!ok)
liberator.echoerr("E20: Mark not set"); // FIXME: move up? liberator.echoerr("E20: Mark not set");
}, },
/** /**

3
common/content/finder.js
View File

@@ -30,7 +30,6 @@ the terms of any one of the MPL, the GPL or the LGPL.
// TODO: proper backwards search - implement our own component? // TODO: proper backwards search - implement our own component?
// : implement our own highlighter? // : implement our own highlighter?
// : frameset pages
// : <ESC> should cancel search highlighting in 'incsearch' mode and jump // : <ESC> should cancel search highlighting in 'incsearch' mode and jump
// back to the presearch page location - can probably use the same // back to the presearch page location - can probably use the same
// solution as marks // solution as marks
@@ -48,8 +47,6 @@ function Finder() //{{{
////////////////////// PRIVATE SECTION ///////////////////////////////////////// ////////////////////// PRIVATE SECTION /////////////////////////////////////////
/////////////////////////////////////////////////////////////////////////////{{{ /////////////////////////////////////////////////////////////////////////////{{{
// FIXME:
//var self = this; // needed for callbacks since "this" is the "liberator" object in a callback
var found = false; // true if the last search was successful var found = false; // true if the last search was successful
var backwards = false; // currently searching backwards var backwards = false; // currently searching backwards
var searchString = ""; // current search string (without modifiers) var searchString = ""; // current search string (without modifiers)

5
common/content/io.js
View File

@@ -878,7 +878,6 @@ lookup:
let dirs = getPathsFromPathList(options["runtimepath"]); let dirs = getPathsFromPathList(options["runtimepath"]);
let found = false; let found = false;
// FIXME: should use original arg string
liberator.echomsg("Searching for \"" + paths.join(" ") + "\" in \"" + options["runtimepath"] + "\"", 2); liberator.echomsg("Searching for \"" + paths.join(" ") + "\" in \"" + options["runtimepath"] + "\"", 2);
outer: outer:
@@ -902,7 +901,7 @@ lookup:
} }
if (!found) if (!found)
liberator.echomsg("not found in 'runtimepath': \"" + paths.join(" ") + "\"", 1); // FIXME: should use original arg string liberator.echomsg("not found in 'runtimepath': \"" + paths.join(" ") + "\"", 1);
return found; return found;
}, },
@@ -1001,7 +1000,7 @@ lookup:
{ {
let lineNumber = i + 1; let lineNumber = i + 1;
// FIXME: messages need to be able to specify // TODO: messages need to be able to specify
// whether they can be cleared/overwritten or // whether they can be cleared/overwritten or
// should be appended to and the MOW opened // should be appended to and the MOW opened
liberator.echoerr("Error detected while processing " + file.path, commandline.FORCE_MULTILINE); liberator.echoerr("Error detected while processing " + file.path, commandline.FORCE_MULTILINE);

2
common/content/liberator.js
View File

@@ -1069,7 +1069,7 @@ const liberator = (function () //{{{
* Opens one or more URLs. Returns true when load was initiated, or * Opens one or more URLs. Returns true when load was initiated, or
* false on error. * false on error.
* *
* @param {FIXME} urls Either a URL string or an array of URLs. * @param {string|string[]} urls Either a URL string or an array of URLs.
* The array can look like this: * The array can look like this:
* ["url1", "url2", "url3", ...] * ["url1", "url2", "url3", ...]
* or: * or:

4
common/content/tabs.js
View File

@@ -401,7 +401,7 @@ function Tabs() //{{{
if (arg) if (arg)
{ {
if (/^\d+$/.test(arg)) if (/^\d+$/.test(arg))
tabs.select("-" + arg, true); // FIXME: urgh! tabs.select("-" + arg, true);
else else
liberator.echoerr("E488: Trailing characters"); liberator.echoerr("E488: Trailing characters");
} }
@@ -989,7 +989,7 @@ function Tabs() //{{{
// FIXME: // FIXME:
if (index == -1) if (index == -1)
{ {
liberator.beep(); // XXX: move to ex-handling? liberator.beep();
return; return;
} }
getBrowser().mTabContainer.selectedIndex = index; getBrowser().mTabContainer.selectedIndex = index;