From 8abe4fd921540a6a668f46d1c5bbb04b26de8e58 Mon Sep 17 00:00:00 2001
From: Kris Maglione <maglione.k@gmail.com>
Date: Tue, 28 Dec 2010 17:27:44 -0500
Subject: [PATCH] Change the order of nodeset filter application in hint
 generation.

--HG--
branch : bootstrapped
---
 common/content/hints.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/common/content/hints.js b/common/content/hints.js
index b2e97bd5..0bdd1d83 100644
--- a/common/content/hints.js
+++ b/common/content/hints.js
@@ -304,14 +304,12 @@ var Hints = Module("hints", {
 
             let mode = this._hintMode;
             let res = util.evaluateXPath(mode.xpath, doc, null, true);
-            if (mode.filter)
-                res = let (orig = res) (e for (e in orig) if (mode.filter(e)));
 
             let start = this._pageHints.length;
             for (let elem in res) {
                 let hint = { elem: elem, showText: false };
 
-                if (!isVisible(elem))
+                if (!isVisible(elem) || mode.filter && !mode.filter(elem))
                     continue;
 
                 if (elem.hasAttributeNS(NS, "hint"))