From a712bf01eaa647bcfe42f882c94f96767a75be72 Mon Sep 17 00:00:00 2001
From: Doug Kearns <dougkearns@gmail.com>
Date: Tue, 30 Oct 2007 08:42:19 +0000
Subject: [PATCH] use -1 as the default value for the ex command count

---
 content/commands.js | 40 +++++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/content/commands.js b/content/commands.js
index e5525b98..f3def65e 100644
--- a/content/commands.js
+++ b/content/commands.js
@@ -181,33 +181,30 @@ vimperator.Commands = function() //{{{
     // FIXME: doesn't really belong here...
     // return [null, null, null, null, heredoc_tag || false];
     //        [count, cmd, special, args] = match;
-    this.parseCommand = function(string, tag)
+    this.parseCommand = function(str, tag)
     {
-        // removing comments
-        string.replace(/\s*".*$/, '');
+        // remove comments
+        str.replace(/\s*".*$/, '');
+
         if (tag) // we already have a multiline heredoc construct
         {
-            if (string == tag)
+            if (str == tag)
                 return [null, null, null, null, false];
             else
-                return [null, null, null, string, tag];
+                return [null, null, null, str, tag];
         }
 
         // 0 - count, 1 - cmd, 2 - special, 3 - args, 4 - heredoc tag
-        var matches = string.match(/^:*(\d+)?([a-zA-Z]+|!)(!)?(?:\s*(.*?)\s*)?$/);
+        var matches = str.match(/^:*(\d+)?([a-zA-Z]+|!)(!)?(?:\s*(.*?)\s*)?$/);
         if (!matches)
             return [null, null, null, null, null];
         matches.shift();
 
         // parse count
         if (matches[0])
-        {
             matches[0] = parseInt(matches[0]);
-            if (isNaN(matches[0]))
-                matches[0] = 0; // 0 is the default if no count given
-        }
         else
-            matches[0] = 0;
+            matches[0] = -1;
 
         matches[2] = !!matches[2];
         matches.push(null);
@@ -286,7 +283,7 @@ vimperator.Commands = function() //{{{
         }
     ));
     addDefaultCommand(new vimperator.Command(["bd[elete]", "bw[ipeout]", "bun[load]", "tabc[lose]"],
-        function(args, special, count) { vimperator.tabs.remove(getBrowser().mCurrentTab, count, special, 0); },
+        function(args, special, count) { vimperator.tabs.remove(getBrowser().mCurrentTab, count > 0 ? count : 1, special, 0); },
         {
             usage: ["[count]bd[elete][!]"],
             short_help: "Delete current buffer (=tab)",
@@ -1523,9 +1520,6 @@ vimperator.Commands = function() //{{{
     addDefaultCommand(new vimperator.Command(["time"],
         function(args, special, count)
         {
-            if (!count || count < 1)
-                count = 1;
-
             try
             {
                 if (count > 1)
@@ -1619,12 +1613,12 @@ vimperator.Commands = function() //{{{
                 {
                     if (undoItems[i].state.entries[0].url == args)
                     {
-                        count = i+1;
+                        count = i + 1;
                         break;
                     }
                 }
             }
-            undoCloseTab(count-1);
+            undoCloseTab(count - 1);
         },
         {
             usage: ["[count]u[ndo][!] [url]"],
@@ -1652,8 +1646,16 @@ vimperator.Commands = function() //{{{
     addDefaultCommand(new vimperator.Command(["undoa[ll]"],
         function(args, special, count)
         {
-            if (count || special)
-                return vimperator.echoerr("E488: Trailing characters");
+            if (count > -1)
+            {
+                vimperator.echoerr("E481: No range allowed");
+                return;
+            }
+            if (special)
+            {
+                vimperator.echoerr("E477: No ! allowed");
+                return;
+            }
 
             var ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
             var undoItems = eval("(" + ss.getClosedTabData(window) + ")");