1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-03-07 02:55:47 +01:00

* Ask for permission when editing external password fields.

* Bump maxVersion to 3.6b1
This commit is contained in:
Martin Stubenschrott
2009-09-24 12:08:47 +02:00
parent 4931f01353
commit a74cc55f6d
4 changed files with 12 additions and 6 deletions

View File

@@ -885,7 +885,7 @@ function Editor() //{{{
}, },
// TODO: clean up with 2 functions for textboxes and currentEditor? // TODO: clean up with 2 functions for textboxes and currentEditor?
editFieldExternally: function () editFieldExternally: function (forceEditing)
{ {
if (!options["editor"]) if (!options["editor"])
return false; return false;
@@ -894,11 +894,15 @@ function Editor() //{{{
if (!(config.isComposeWindow)) if (!(config.isComposeWindow))
textBox = liberator.focus; textBox = liberator.focus;
if (textBox.type == "password") if (!forceEditing && textBox && textBox.type == "password")
{ {
liberator.beep(); commandline.input("Editing a password field externally will reveal the password. Would you like to continue? (yes/[no]): ",
liberator.echoerr("Cannot edit password fields"); function (resp)
return false; {
if (resp && resp.match(/^y(es)?$/i))
return editor.editFieldExternally(true);
});
return;
} }
let text = ""; // XXX let text = ""; // XXX

View File

@@ -1,2 +1,3 @@
2009: 2009:
* Andreas Nerf (biggest Muttator donor so far! thanks a lot)
* Kirill Korotaev * Kirill Korotaev

View File

@@ -2,6 +2,7 @@ Continuous donations:
* Daniel Bainton (web hosting) * Daniel Bainton (web hosting)
2009: 2009:
* Oliver Schaefer (2nd donation this year, and largest one in 2009! - Thanks!)
* James Davis * James Davis
* Gregg Archer * Gregg Archer
* James Henderson * James Henderson

View File

@@ -19,7 +19,7 @@
<Description> <Description>
<em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id> <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
<em:minVersion>3.5</em:minVersion> <em:minVersion>3.5</em:minVersion>
<em:maxVersion>3.6a2pre</em:maxVersion> <em:maxVersion>3.6b1pre</em:maxVersion>
</Description> </Description>
</em:targetApplication> </em:targetApplication>
</Description> </Description>