gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-22 21:27:58 +01:00
Code Issues Projects Releases Wiki Activity

Fix bookmark tag editing via :bmark.

Browse Source 
Places transactions are essentially irrelevant given the current
bookmark interface, though could perhaps be supported in the future.
This commit is contained in:
Doug Kearns
2009-08-09 23:53:41 +10:00
parent 2392a2841f
commit a8001baa03
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
common/content/bookmarks.js
View File

@@ -537,13 +537,14 @@ function Bookmarks() //{{{
// if "bypassCache" is true, it will force a reload of the bookmarks database // if "bypassCache" is true, it will force a reload of the bookmarks database
// on my PC, it takes about 1ms for each bookmark to load, so loading 1000 bookmarks // on my PC, it takes about 1ms for each bookmark to load, so loading 1000 bookmarks
// takes about 1 sec // takes about 1 sec
// Huh? --djk
// TODO: why is this a filter? --djk
get: function get(filter, tags, maxItems, extra) get: function get(filter, tags, maxItems, extra)
{ {
return completion.runCompleter("bookmark", filter, maxItems, tags, extra); return completion.runCompleter("bookmark", filter, maxItems, tags, extra);
}, },
// if starOnly = true it is saved in the unfiledBookmarksFolder, otherwise in the bookmarksMenuFolder // if starOnly = true it is saved in the unfiledBookmarksFolder, otherwise in the bookmarksMenuFolder
// FIXME: tags are not updated differentially
add: function add(starOnly, title, url, keyword, tags, force) add: function add(starOnly, title, url, keyword, tags, force)
{ {
try try
@@ -573,8 +574,7 @@ function Bookmarks() //{{{
bookmarksService.setKeywordForBookmark(id, keyword); bookmarksService.setKeywordForBookmark(id, keyword);
if (tags) if (tags)
{ {
// TODO: presumably this needs to be done in two Places transactions *double yawn* --djk taggingService.untagURI(uri, null);
//taggingService.untagURI(uri, null);
taggingService.tagURI(uri, tags); taggingService.tagURI(uri, tags);
} }
} }