From ab057c17a60b65742dfe966c95fb937f971e1965 Mon Sep 17 00:00:00 2001 From: Doug Kearns Date: Tue, 25 Nov 2008 14:23:16 +0000 Subject: [PATCH] add comment about recent literalArg handling change in commands#parseArgs --- content/commands.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/content/commands.js b/content/commands.js index e45ccc06..c81373aa 100644 --- a/content/commands.js +++ b/content/commands.js @@ -422,6 +422,16 @@ function Commands() //{{{ options = []; if (literal) + /* + TODO: This change doesn't seem right to me. It no longer + supports "?" which is really the only non-integer argCount + that makes much sense with a literal arg. Likewise, it no + longer supports "*" which we can allow and treat as "?" - "+" + as "1". I also don't like having argCounts > 1 specified as + integers and those below as strings, even if the former are + currently only used with 'literal'. I might be missing + something? -- djk + */ var literalIndex = argCount == "+" ? 0 : Math.max(argCount - 1, 0); if (!argCount)