gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2026-01-06 16:04:12 +01:00
Code Issues Projects Releases Wiki Activity

Fix observer cleanup issue.

Browse Source
This commit is contained in:
Kris Maglione
2013-03-24 11:39:42 -07:00
parent 3fbfb910e1
commit b5ffc5680d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
common/modules/storage.jsm
View File

@@ -276,10 +276,15 @@ var Storage = Module("Storage", {
}, },
removeDeadObservers: function () { removeDeadObservers: function () {
function filter(o) {
if (!o.callback.get())
return false;
let ref = o.ref && o.ref.get();
return ref && !ref.closed && overlay.getData(ref, "storage-refs", null);
}
for (let [key, ary] in Iterator(this.observers)) { for (let [key, ary] in Iterator(this.observers)) {
this.observers[key] = ary = ary.filter(function (o) o.callback.get() this.observers[key] = ary = ary.filter(filter);
&& (!o.ref || o.ref.get()
&& overlay.getData(o.ref.get(), "storage-refs", null)));
if (!ary.length) if (!ary.length)
delete this.observers[key]; delete this.observers[key];
} }