From 202975b3f1eb63ca768ae18f795527f97473ff64 Mon Sep 17 00:00:00 2001 From: Doug Kearns Date: Tue, 17 Mar 2009 00:29:16 +1100 Subject: [PATCH 1/3] Add extension ID update reminder to TODO. --- vimperator/TODO | 2 ++ 1 file changed, 2 insertions(+) diff --git a/vimperator/TODO b/vimperator/TODO index c2175204..d6f0d711 100644 --- a/vimperator/TODO +++ b/vimperator/TODO @@ -39,6 +39,8 @@ BUGS: - URLs in :ls output are no longer hyperlinks FEATURES: +9 change the extension ID to vimperator@vimperator.org rather than + vimperator@mozdev.org 9 finish :help TODOs 9 fix local options 9 adaptive timeout for auto-completions, :set completions can be updated more often than From 79ef0f67eb89d240f448afa614d5ffee5048088f Mon Sep 17 00:00:00 2001 From: Doug Kearns Date: Wed, 18 Mar 2009 20:32:41 +1100 Subject: [PATCH 2/3] Don't bother forking colorscheme completion. It was an attempt to improve on Vim's colorscheme completion, across multiple runtime paths, but that's more buggy than useful. --- common/content/completion.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/common/content/completion.js b/common/content/completion.js index ee86368d..5c8e9d2d 100644 --- a/common/content/completion.js +++ b/common/content/completion.js @@ -1426,15 +1426,17 @@ function Completion() //{{{ colorScheme: function colorScheme(context) { - // TODO: use path for the description? + let colors = []; + io.getRuntimeDirectories("colors").forEach(function (dir) { - context.fork(dir.path, 0, null, function (context) { - context.filter = dir.path + io.pathSeparator + context.filter; - completion.file(context); - context.title = ["Color Scheme"]; - context.quote = ["", function (text) text.replace(/\.vimp$/, ""), ""]; + io.readDirectory(dir).forEach(function (file) { + if (/\.vimp$/.test(file.leafName) && !colors.some(function (c) c.leafName == file.leafName)) + colors.push(file); }); }); + + context.title = ["Color Scheme", "Runtime Path"]; + context.completions = [[c.leafName.replace(/\.vimp$/, ""), c.parent.path] for ([,c] in Iterator(colors))] }, command: function command(context) From 855bc5b9fe26ad0a4d4734ed64fe965af51ed2bb Mon Sep 17 00:00:00 2001 From: Daniel Bainton Date: Wed, 18 Mar 2009 22:39:32 +0200 Subject: [PATCH 3/3] Revert "Fix bug #189, now uses first completion" This reverts commit f18efe4ec792afb65c4bace11073526aef31725e. --- common/content/ui.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/common/content/ui.js b/common/content/ui.js index a23e5de7..d01f2a2c 100644 --- a/common/content/ui.js +++ b/common/content/ui.js @@ -1298,15 +1298,8 @@ function CommandLine() //{{{ // user pressed ENTER to carry out a command // user pressing ESCAPE is handled in the global onEscape // FIXME: should trigger "cancel" event - // FIXME: This should not be waiting, some kind of callback mechanism on completion would be better. if (events.isAcceptKey(key)) { - while (completions.context.incomplete) - { - liberator.threadYield(true); - command = this.command; - } - let mode = currentExtendedMode; // save it here, as modes.pop() resets it keepCommand = true; currentExtendedMode = null; // Don't let modes.pop trigger "cancel"