gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-21 09:48:00 +01:00
Code Issues Projects Releases Wiki Activity

Fix minor completion error, also allow quoting of commas in LIST command arguments.

Browse Source 
--HG--
extra : rebase_source : b05a7ea4c41e540adec38f34a8a60b3431bd87a1
This commit is contained in:
Kris Maglione
2010-12-24 20:38:23 -05:00
parent 879cb52279
commit c507f63194
1 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
common/content/commands.js
View File

@@ -80,7 +80,7 @@ update(CommandOption, {
* E.g. "foo,bar" * E.g. "foo,bar"
* @final * @final
*/ */
LIST: ArgType("list", function (arg) arg && arg.split(/\s*,\s*/)) LIST: ArgType("list", function (arg, quoted) Option.splitList(quoted))
}); });
/** /**
@@ -748,7 +748,10 @@ const Commands = Module("commands", {
*/ */
parseArgs: function (str, params) { parseArgs: function (str, params) {
try { try {
function getNextArg(str) { function getNextArg(str, _keepQuotes) {
if (arguments.length < 2)
_keepQuotes = keepQuotes;
if (str.substr(0, 2) === "<<" && hereDoc) { if (str.substr(0, 2) === "<<" && hereDoc) {
let arg = /^<<(\S*)/.exec(str)[1]; let arg = /^<<(\S*)/.exec(str)[1];
let count = arg.length + 2; let count = arg.length + 2;
@@ -756,7 +759,7 @@ const Commands = Module("commands", {
return [count, "", ""]; return [count, "", ""];
return [count, io.readHeredoc(arg), ""]; return [count, io.readHeredoc(arg), ""];
} }
let [count, arg, quote] = Commands.parseArg(str, null, keepQuotes); let [count, arg, quote] = Commands.parseArg(str, null, _keepQuotes);
if (quote == "\\" && !complete) if (quote == "\\" && !complete)
return [, , , "Trailing \\"]; return [, , , "Trailing \\"];
if (quote && !complete) if (quote && !complete)
@@ -782,7 +785,7 @@ const Commands = Module("commands", {
var invalid = false; var invalid = false;
// FIXME: best way to specify these requirements? // FIXME: best way to specify these requirements?
var onlyArgumentsRemaining = allowUnknownOptions || options.length == 0; // after a -- has been found var onlyArgumentsRemaining = allowUnknownOptions || options.length == 0; // after a -- has been found
var arg = null; var arg = null, quoted = null;
var count = 0; // the length of the argument var count = 0; // the length of the argument
var i = 0; var i = 0;
var completeOpts; var completeOpts;
@@ -845,12 +848,14 @@ const Commands = Module("commands", {
for (let [, optname] in Iterator(opt.names)) { for (let [, optname] in Iterator(opt.names)) {
if (sub.indexOf(optname) == 0) { if (sub.indexOf(optname) == 0) {
invalid = false; invalid = false;
quoted = null;
arg = null; arg = null;
quote = null; quote = null;
count = 0; count = 0;
let sep = sub[optname.length]; let sep = sub[optname.length];
if (sep == "=" || /\s/.test(sep) && opt.type != CommandOption.NOARG) { if (sep == "=" || /\s/.test(sep) && opt.type != CommandOption.NOARG) {
[count, arg, quote, error] = getNextArg(sub.substr(optname.length + 1)); [count, quoted, quote, error] = getNextArg(sub.substr(optname.length + 1), true);
arg = Option.dequote(quoted);
dactyl.assert(!error, error); dactyl.assert(!error, error);
// if we add the argument to an option after a space, it MUST not be empty // if we add the argument to an option after a space, it MUST not be empty
@@ -879,7 +884,7 @@ const Commands = Module("commands", {
if (!complete || arg != null) { if (!complete || arg != null) {
if (opt.type) { if (opt.type) {
let orig = arg; let orig = arg;
arg = opt.type.parse(arg); arg = opt.type.parse(arg, quoted);
if (complete && isArray(arg)) { if (complete && isArray(arg)) {
args.completeFilter = arg[arg.length - 1]; args.completeFilter = arg[arg.length - 1];
@@ -896,7 +901,7 @@ const Commands = Module("commands", {
// we have a validator function // we have a validator function
if (typeof opt.validator == "function") { if (typeof opt.validator == "function") {
if (opt.validator.call(this, arg) == false) { if (opt.validator.call(this, arg, quoted) == false) {
fail("Invalid argument for option: " + optname); fail("Invalid argument for option: " + optname);
if (complete) // Always true. if (complete) // Always true.
complete.highlight(args.completeStart, count - 1, "SPELLCHECK"); complete.highlight(args.completeStart, count - 1, "SPELLCHECK");
@@ -904,6 +909,7 @@ const Commands = Module("commands", {
} }
} }
if (arg != null || opt.type == CommandOption.NOARG)
// option allowed multiple times // option allowed multiple times
if (opt.multiple) if (opt.multiple)
args[opt.names[0]] = (args[opt.names[0]] || []).concat(arg); args[opt.names[0]] = (args[opt.names[0]] || []).concat(arg);