gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-22 00:07:58 +01:00
Code Issues Projects Releases Wiki Activity

attempt to fix problems with hints on not finished page load, should fix messages to the error console

Browse Source
This commit is contained in:
Martin Stubenschrott
2007-08-10 01:38:59 +00:00
parent c9229435c3
commit cb3d007341
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
chrome/content/vimperator/hints.js
View File

@@ -70,6 +70,10 @@ function Hints() //{{{
this.loadCoord = function(winId, i) this.loadCoord = function(winId, i)
{ {
// win.res is not ready when loading has not finished yet
if(!win.res)
return;
win = wins[winId]; win = wins[winId];
var elem = win.res.snapshotItem(i); var elem = win.res.snapshotItem(i);
@@ -88,7 +92,7 @@ function Hints() //{{{
{ {
// NOTE: experiment for making the function faster, report problems // NOTE: experiment for making the function faster, report problems
// only works for FF3.0: // only works for FF3.0:
//var rect = elem.getBoundingClientRect(); //var rect = elem.getClientRects()[0];
//if (rect) //if (rect)
//{ //{
// elem.absoLeft = rect.left; // elem.absoLeft = rect.left;
@@ -144,6 +148,8 @@ function Hints() //{{{
{ {
genHintContainer(doc); genHintContainer(doc);
hintContainer = doc.getElementById('hah_hints'); hintContainer = doc.getElementById('hah_hints');
if (!hintContainer)
return false;
} }
hintContainer.valid_hint_count = 0; // none of these hints should be visible initially hintContainer.valid_hint_count = 0; // none of these hints should be visible initially
@@ -207,7 +213,13 @@ function Hints() //{{{
if (linkCount == 0 && !vimperator.hasMode(vimperator.modes.ALWAYS_HINT)) if (linkCount == 0 && !vimperator.hasMode(vimperator.modes.ALWAYS_HINT))
{ {
vimperator.beep(); vimperator.beep();
this.disableHahMode(win);
// FIXME: this.disableHahMode(win);
vimperator.setMode(vimperator.modes.NORMAL);
isHahModeEnabled = false;
linkNumString = '';
hintedElems = [];
return; return;
} }
@@ -406,7 +418,7 @@ function Hints() //{{{
* @return -1 if already disabled * @return -1 if already disabled
*/ */
//function disableHahMode(event) //function disableHahMode(event)
this.disableHahMode = function(win, silent) this.disableHahMode = function(win)
{ {
if(!isHahModeEnabled) if(!isHahModeEnabled)
return; return;
@@ -630,7 +642,8 @@ function Hints() //{{{
hints = doc.createElement('HINTS'); hints = doc.createElement('HINTS');
hints.id = "hah_hints"; hints.id = "hah_hints";
hints.valid_hint_count = 0; // initially 0 elements are usable as hints hints.valid_hint_count = 0; // initially 0 elements are usable as hints
doc.body.appendChild(hints); if(doc.body)
doc.body.appendChild(hints);
} }
function initDoc(event) function initDoc(event)