From d90e670d7068c84a33dbc4e0212b374bc151765e Mon Sep 17 00:00:00 2001 From: Ted Pavlic Date: Thu, 8 Jan 2009 08:51:34 -0500 Subject: [PATCH] Revert 93b0cf2a063b045268a55fbeac9473ce12234300's changes to hints.js Until liberator.NEW_BACKGROUND_TAB operates differently based on the setting of browser.tabs.loadInBackground, this code must remain. At the moment, NEW_BACKGROUND_TAB only opens a true background tab if loadInBackground=true. When loadInBackground=false, the meaning of NEW_TAB and NEW_BACKGROUND_TAB flip. Hence, until they're invariant, something like ;F (which must always load tabs in the background) has to pay attention to loadInBackground. --- common/content/hints.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/common/content/hints.js b/common/content/hints.js index 5ae1e892..cdc90dfb 100644 --- a/common/content/hints.js +++ b/common/content/hints.js @@ -86,7 +86,13 @@ function Hints() //{{{ // Used to open multiple hints function hintSequenceElement(elem) { - buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB); + // Want to always open sequence hints in background + // (remember: NEW_BACKGROUND_TAB and NEW_TAB semantics assume + // that loadInBackground=true) + if (options.getPref("browser.tabs.loadInBackground")) + buffer.followLink(elem, liberator.NEW_BACKGROUND_TAB); + else + buffer.followLink(elem, liberator.NEW_TAB); // Move to next element in sequence // TODO: Maybe we find a *simple* way to keep the hints displayed rather than