From e238c1d36115684a8a5d1112f570f27d00efe3aa Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Mon, 27 Sep 2010 16:24:06 -0400 Subject: [PATCH] Fix stringlist option completion. --- common/content/options.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/common/content/options.js b/common/content/options.js index 8ee4da6b..d9acee9e 100644 --- a/common/content/options.js +++ b/common/content/options.js @@ -437,11 +437,11 @@ const Option = Class("Option", { let res = []; Option._splitAt = 0; do { - if (count !== undefined) - Option._splitAt += count + 1; var [count, arg, quote] = Commands.parseArg(value, /,/, keepQuotes); Option._quote = quote; // FIXME res.push(arg); + if (value.length > count) + Option._splitAt += count + 1; value = value.slice(count + 1); } while (value.length); return res; @@ -1395,7 +1395,6 @@ const Options = Module("options", { newValues = Option.splitList(context.filter); // Fallthrough case "stringlist": - var target = newValues.pop() || ""; break; case "stringmap": case "regexmap": @@ -1406,7 +1405,7 @@ const Options = Module("options", { } // TODO: Highlight when invalid context.advance(Option._splitAt); - context.filter = target != null ? target : Option.dequote(context.filter); + context.filter = Option.dequote(context.filter); context.title = ["Option Value"]; context.quote = Commands.complQuote[Option._quote] || Commands.complQuote[""]