From e40b0c95add362f05501d6b2416634638f613633 Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Thu, 14 Oct 2010 15:53:01 -0400 Subject: [PATCH] Remove onKeyUpOrDown handler, which doesn't explain its purpose well enough to survive. Fixes issue #76. --- common/content/events.js | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/common/content/events.js b/common/content/events.js index 8069da69..93ae7dfb 100644 --- a/common/content/events.js +++ b/common/content/events.js @@ -76,9 +76,7 @@ const Events = Module("events", { this.addSessionListener(window, "DOMMenuBarActive", this.closure.onDOMMenuBarActive, true); this.addSessionListener(window, "DOMMenuBarInactive", this.closure.onDOMMenuBarInactive, true); this.addSessionListener(window, "focus", this.wrapListener(this.onFocus), true); - this.addSessionListener(window, "keydown", this.wrapListener(this.onKeyUpOrDown), true); this.addSessionListener(window, "keypress", this.wrapListener(this.onKeyPress), true); - this.addSessionListener(window, "keyup", this.wrapListener(this.onKeyUpOrDown), true); this.addSessionListener(window, "mousedown", this.wrapListener(this.onMouseDown), true); this.addSessionListener(window, "popuphidden", this.closure.onPopupHidden, true); this.addSessionListener(window, "popupshown", this.closure.onPopupShown, true); @@ -574,7 +572,6 @@ const Events = Module("events", { * @returns {boolean} */ waitForPageLoad: function () { - //util.dump("start waiting in loaded state: " + buffer.loaded); util.threadYield(true); // clear queue if (buffer.loaded == 1) @@ -586,8 +583,6 @@ const Events = Module("events", { let now; while (now = Date.now(), now < end) { util.threadYield(); - //if ((now - start) % 1000 < 10) - // util.dump("waited: " + (now - start) + " ms"); if (!events.feedingKeys) return false; @@ -939,12 +934,6 @@ const Events = Module("events", { } }, - // this is need for sites like msn.com which focus the input field on keydown - onKeyUpOrDown: function onKeyUpOrDown(event) { - if (!Events.isInputElemFocused() && !modes.passThrough) - event.stopPropagation(); - }, - onMouseDown: function onMouseDown(event) { let elem = event.target; let win = elem.ownerDocument && elem.ownerDocument.defaultView || elem;