From e594e4ca3569b12b3fd314fdfaeafbb2d8f4391a Mon Sep 17 00:00:00 2001
From: Kris Maglione <maglione.k@gmail.com>
Date: Wed, 19 Jan 2011 05:44:27 -0500
Subject: [PATCH] Fix :com -complete. Allow directly specifying static
 completion results. Allow command aliases separated by commas.

---
 common/content/commands.js    | 21 +++++++++++----------
 pentadactyl/content/config.js |  4 ++--
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/common/content/commands.js b/common/content/commands.js
index 7af444b4..749cdf36 100644
--- a/common/content/commands.js
+++ b/common/content/commands.js
@@ -1049,7 +1049,7 @@ var Commands = Module("commands", {
         ]]>)
     }),
 
-    validName: Class.memoize(function () RegExp("^" + this.nameRegexp.source + "$")),
+    validName: Class.memoize(function () util.regexp("^" + this.nameRegexp.source + "$")),
 
     commandRegexp: Class.memoize(function () util.regexp(<![CDATA[
             ^
@@ -1277,7 +1277,8 @@ var Commands = Module("commands", {
             function (args) {
                 let cmd = args[0];
 
-                dactyl.assert(!cmd || commands.validName.test(cmd), "E182: Invalid command name");
+                dactyl.assert(!cmd || cmd.split(",").every(commands.validName.closure.test),
+                              "E182: Invalid command name");
 
                 if (args.literalArg) {
                     let completer  = args["-complete"];
@@ -1286,12 +1287,9 @@ var Commands = Module("commands", {
                     if (completer) {
                         if (/^custom,/.test(completer)) {
                             completer = completer.substr(7);
-                            completerFunc = function () {
+                            completerFunc = function (context) {
                                 try {
-                                    var completer = dactyl.userEval(completer);
-
-                                    if (!callable(completer))
-                                        throw new TypeError("User-defined custom completer " + completer.quote() + " is not a function");
+                                    var result = dactyl.userEval(completer);
                                 }
                                 catch (e) {
                                     dactyl.echo(":" + this.name + " ...");
@@ -1299,14 +1297,17 @@ var Commands = Module("commands", {
                                     dactyl.log(e);
                                     return undefined;
                                 }
-                                return completer.apply(this, Array.slice(arguments));
+                                if (callable(result))
+                                    return result.apply(this, Array.slice(arguments));
+                                else
+                                    return context.completions = result;
                             };
                         }
                         else
                             completerFunc = function (context) completion.closure[completerMap[completer]](context);
                     }
 
-                    let added = commands.addUserCommand([cmd],
+                    let added = commands.addUserCommand(cmd.split(","),
                                     args["-description"],
                                     Command.bindMacro(args, "-ex",
                                         function makeParams(args, modifiers) ({
@@ -1368,7 +1369,7 @@ var Commands = Module("commands", {
                         description: "The argument completion function",
                         completer: function (context) [[k, ""] for ([k, v] in Iterator(completerMap))],
                         type: CommandOption.STRING,
-                        validator: function (arg) arg in completerMap || /custom,\w+/.test(arg),
+                        validator: function (arg) arg in completerMap || /^custom,/.test(arg),
                     }, {
                         names: ["-description", "-desc", "-d"],
                         description: "A user-visible description of the command",
diff --git a/pentadactyl/content/config.js b/pentadactyl/content/config.js
index 2539ad9f..19644e51 100644
--- a/pentadactyl/content/config.js
+++ b/pentadactyl/content/config.js
@@ -17,6 +17,8 @@ var Config = Module("config", ConfigBase, {
     Local: function Local(dactyl, modules, window)
         let ({ config } = modules) ({
 
+        completers: Class.memoize(function () update({ sidebar: "sidebar", window: "window" }, this.__proto__.completers)),
+
         dialogs: {
             about: ["About Firefox",
                 function () { window.openDialog("chrome://browser/content/aboutDialog.xul", "_blank", "chrome,dialog,modal,centerscreen"); }],
@@ -126,8 +128,6 @@ var Config = Module("config", ConfigBase, {
         Leave: "Triggered before exiting Firefox"
     },
 
-    completers: Class.memoize(function () update({ sidebar: "sidebar", window: "window" }, this.__proto__.completers)),
-
     defaults: {
         complete: "slf",
         guioptions: "bCrs",