gryf/pentadactyl-pm
1
0
Fork 0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 06:07:59 +01:00
Code Issues Projects Releases Wiki Activity

Rename :tabreattach to :tabattach.

Browse Source 
As Kris noted this may be better implemented as :tabmove -window.
This commit is contained in:
Doug Kearns
2009-09-30 19:48:34 +10:00
parent 422579f6e2
commit f79c6e8dc1
7 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
common/content/tabs.js
View File

@@ -621,15 +621,15 @@ function Tabs() //{{{
// TODO: match window by title too?
// : accept the full :tabmove arg spec for the tab index arg?
// : better name or merge with :tabmove?
commands.add(["tabrea[ttach]"],
"Reattach the current tab to another window",
commands.add(["taba[ttach]"],
"Attach the current tab to another window",
function (args)
{
if (args.length > 2 || args.some(function (i) i && !/^\d+$/.test(i)))
return void liberator.echoerr("E488: Trailing characters");
let [winIndex, tabIndex] = args;
let win = liberator.windows[winIndex];
let [winIndex, tabIndex] = args.map(parseInt);
let win = liberator.windows[winIndex - 1];
if (!win)
return void liberator.echoerr("Window " + winIndex + " does not exist");
@@ -638,12 +638,16 @@ function Tabs() //{{{
let browser = win.getBrowser();
let dummy = browser.addTab("about:blank");
browser.stop();
// XXX: the implementation of DnD in tabbrowser.xml suggests
// that we may not be guaranteed of having a docshell here
// without this reference?
browser.docShell;
let last = browser.mTabs.length - 1;
browser.moveTabTo(dummy, util.Math.constrain(tabIndex || last, 0, last));
browser.selectedTab = dummy; // required
browser.stop();
browser.docShell;
browser.swapBrowsersAndCloseOther(dummy, getBrowser().mCurrentTab);
},
{
@@ -651,7 +655,10 @@ function Tabs() //{{{
completer: function (context, args)
{
if (args.completeArg == 0)
{
context.filters.push(function ({ item: win }) win != window);
completion.window(context);
}
}
});
}