From f9bbe484df24aec41534e4e5dd7343b70358d83c Mon Sep 17 00:00:00 2001 From: Kris Maglione Date: Wed, 29 Dec 2010 21:10:25 -0500 Subject: [PATCH] Fix passing and causing a history back event in command line mode. Fix reinitialization when not purging module globals. --- common/bootstrap.js | 5 +++-- common/content/commandline.js | 11 ++++------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/common/bootstrap.js b/common/bootstrap.js index 2b5d6402..4ce89386 100755 --- a/common/bootstrap.js +++ b/common/bootstrap.js @@ -147,13 +147,14 @@ function init() { } } - Services.obs.notifyObservers(null, "dactyl-rehash", null); - JSMLoader.load("resource://dactyl/base.jsm", global); for each (let component in components) component.register(); + Services.obs.notifyObservers(null, "dactyl-rehash", null); + JSMLoader.load("resource://dactyl/base.jsm", global); + require(global, "services"); let manifestText = result.map(function (line) line.join(" ")).join("\n"); diff --git a/common/content/commandline.js b/common/content/commandline.js index fa656d09..873ac941 100644 --- a/common/content/commandline.js +++ b/common/content/commandline.js @@ -935,10 +935,11 @@ var CommandLine = Module("commandline", { } else if (event.type == "keypress") { let key = events.toString(event); + util.dump("keypress", key, Events.isEscape(event)); if (this._completions) this._completions.previewClear(); if (!this.currentExtendedMode) - return; + return !Events.isEscape(event); // user pressed to carry out a command // user pressing is handled in the global onEscape @@ -977,10 +978,8 @@ var CommandLine = Module("commandline", { modes.pop(); } } - else { - //this.resetCompletions(); - } // allow this event to be handled by the host app + return !Events.isEscape(event); } else if (event.type == "keyup") { let key = events.toString(event); @@ -991,9 +990,7 @@ var CommandLine = Module("commandline", { catch (e) { dactyl.reportError(e, true); } - finally { - return true; - } + return true; }, /**