1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-20 05:37:58 +01:00
Commit Graph

211 Commits

Author SHA1 Message Date
Kris Maglione
a72068c9f7 Refactor modules.config. 2009-11-09 03:12:27 -05:00
Kris Maglione
6a25312c7d Recfactoring:
* Standard module format. All modules are explicitly declared
   as modules, they're created via a constructor and
   instantiated automatically. They're dependency aware. They
   stringify properly.

 * Classes are declared the same way (rather like Structs
   already were). They also stringify properly. Plus, each
   instance has a rather nifty closure member that closes all
   of its methods around 'this', so you can pass them to map,
   forEach, setTimeout, etc. Modules are themselves classes,
   with a special metaclass, as it were.

 * Doug Crockford is dead, metaphorically speaking.
   Closure-based classes just don't fit into any of the common
   JavaScript frameworks, and they're inefficient and
   confusing. Now, all class and module members are accessed
   explicitly via 'this', which makes it very clear that
   they're class members and not (e.g.) local variables,
   without anything nasty like Hungarian notation.

 * Strictly one module per file. Classes that belong to a
   module live in the same file.

 * For the moment, there are quite a few utility functions
   sitting in base.c, because my class implementation used
   them, and I haven't had the time or inclination to sort them
   out. I plan to reconcile them with the current mess that is
   the util namespace.

 * Changed bracing style.
2009-11-08 20:54:31 -05:00
Kris Maglione
1ce498401e Add liberator.assert. 2009-11-03 02:36:48 -05:00
Kris Maglione
7a9889b18c Add IO#File.
New review:
owner: dougkearns
I like this for the most part, except that it has to go to lengths
to wrap the original nsIFile correctly, an that it can't be passed
directly to other XPCOM components. It makes most operations on
files a lot cleaner, though.
2009-10-31 17:40:16 -04:00
Kris Maglione
9e531ca343 Fix Xulmus, etc.
--HG--
branch : xslt
2009-10-25 13:43:25 -04:00
Doug Kearns
9c2f01bfea Remove no-opping of arbitrary bindings in INSERT mode.
This list of keys is completely arbitrary, a small subset of Firefox's
supposedly undesirable bindings, and still manages to break three default
bindings on GTK/Firefox. INSERT mode is essentially a pass-through mode. If
that's not desirable then a new enhancement issue should be opened.

Fixes issue #58.
2009-10-16 00:25:09 +11:00
Doug Kearns
34f8dcbd2f Remove fixed FIXME comment. 2009-10-13 21:17:24 +11:00
Doug Kearns
29de612097 Fix escaping from Textarea mode in input fields.
When escaping from Textarea mode in input fields, and also text areas if
'insertmode' is set, return to Insert mode.
2009-10-11 01:38:11 +11:00
Martin Stubenschrott
3910c0604b Move all files to a MIT license 2009-10-03 00:32:29 +02:00
Martin Stubenschrott
a74cc55f6d * Ask for permission when editing external password fields.
* Bump maxVersion to 3.6b1
2009-09-24 12:11:29 +02:00
Doug Kearns
e1abaf5d9a Fix typo in i_<Insert> definition. 2009-09-16 12:47:49 +10:00
Martin Stubenschrott
4d4da18b49 fix whitespace from last commit 2009-09-11 22:27:15 +02:00
Martin Stubenschrott
fcc1cffc88 disallow editing of password fields 2009-09-11 22:23:06 +02:00
Doug Kearns
2b7e4dcb67 Remove redundant semicolons. 2009-09-04 21:58:43 +10:00
Doug Kearns
c958616337 Formatting fixes. 2009-08-27 14:46:30 +10:00
Doug Kearns
776f9bb425 Cleanup some references to "Firefox" in common/*. 2009-06-28 16:03:23 +10:00
Doug Kearns
6f2eb2d1ef Split Map.flags into individual properties of Map. 2009-06-28 16:03:21 +10:00
Doug Kearns
ec8d7686fc Move the standard type completers to appropriate modules. 2009-06-18 22:02:21 +10:00
Doug Kearns
09d8af9044 Change multiline beep guard clauses to single line formatting. 2009-06-04 14:30:46 +10:00
Doug Kearns
6d7b94daa6 Add missing semicolons. 2009-06-02 16:59:24 +10:00
Doug Kearns
26dabbfd0d Change multiline error message guard clauses to single line formatting.
Also apply similar formattng fixes to conditional blocks as per
standard.
2009-05-22 10:53:17 +10:00
Doug Kearns
f834cfcd6b Add some API documentation for Options and others. 2009-05-22 10:53:06 +10:00
Doug Kearns
2c486edee7 Fix conditional in editor.executeCommandWithMotion. 2009-05-15 00:29:50 +10:00
Kris Maglione
dbf60914ab Add 'fileencoding' 2009-05-01 15:19:35 -04:00
Kris Maglione
2f753b6d27 Fix #247 2009-04-22 13:15:56 -04:00
Martin Stubenschrott
5ab1771e3c changed my email address 2009-03-28 23:38:33 +01:00
Daniel Bainton
ae150a373e Fix bug #93 the hacky way, thanks to Conrad Irwin for the patch. 2009-03-15 03:27:07 +02:00
Doug Kearns
a37f61028d Fix editor#pasteClipboard on Windows. 2009-03-13 18:06:20 +11:00
Daniel Bainton
466e521230 Revert "Replace use of editor.pasteClipboard with executeCommand("cmd_paste")."
This reverts commit 7e8db4743b24368ba1784420e6cdf6b4838958df.

The commit breaks selection pasting in linux, so reverting.
2009-03-08 20:35:16 +02:00
Doug Kearns
52956a9aa1 Replace use of editor.pasteClipboard with executeCommand("cmd_paste").
This fixes #93 (<s-insert> in the bottom of a long textarea bounces up)
as well.
2009-03-09 01:18:57 +11:00
anekos
e459c7c867 Escaping the error.
A error occurs if the element has been removed when "elem.selectionStart" is executed.

e.g.
  Press "gi<ESC>" on
  <input type="text" onfocus="this.parentNode.removeChild(this)" />
2009-02-23 04:55:51 +09:00
Kris Maglione
eb88d7ea0b Sorry, stashed changes including:
Change util.range to accept an increment as the third argument.
    Sanitize Makefile.doc
2009-01-21 03:41:43 -05:00
Ted Pavlic
1f93e422e7 Fixed (:abbr """a b) so it stopped throwing E114 (like Vim). 2009-01-20 11:28:32 -05:00
Ted Pavlic
21c4f0f89e Setup abbreviation behavior to be like an isk-less Vim.
For now, the internal equivalent of "iskeyword" is [^\s'"].

In the future, the internal "iskeyword" equivalent can be expanded. It may
be overboard to add an "iskeyword" option, as it applies to lots more
things than :abbr. Additionally, it's not clear why it's bad to call
keyword characters everything except whitespace and quotes.

TODO: Should abbreviations be triggered by any non-keyword character?

TODO: Should abbreviations be triggered by <CR>?

TODO: Should abbreviations be able to include <Left>, etc.?
2009-01-17 00:39:01 -05:00
Ted Pavlic
ba948246cc Fix ":abbr this'is'a'test" to return an error, like Vim.
Also note in map.txt that :abbr LHS cannot contain quotes or spaces.
2009-01-16 15:33:43 -05:00
Ted Pavlic
22d3bc470b Change :abbr to parse its args.string itself. 2009-01-16 15:22:44 -05:00
Ted Pavlic
a2c0233fc0 After some investigation, it appears like Vim only outlaws quotes in :abbr.
TODO: Make

    :abbr abcd\ efgh

work like Vim (i.e., map abcd\ to efgh). That's a bigger change to how
the command line is parsed.
2009-01-16 14:59:36 -05:00
Ted Pavlic
aca074f82b Fix :abbr with no argument (in future, will be less push happy). 2009-01-16 14:25:56 -05:00
Ted Pavlic
704303c108 Moved :abbr LHS non-word match to outside RHS check. Want to check LHS always (like Vim). 2009-01-16 14:19:17 -05:00
Ted Pavlic
b758e2f729 Make sure LHS of :abbr is is all word characters. E474 otherwise (mimic Vim). 2009-01-16 14:02:04 -05:00
Ted Pavlic
1019daa5ca Change (\S+) to (\w+) in abbreviation matching so that "VIMP<space> expands (to match Vim behavior). 2009-01-16 13:34:05 -05:00
Kris Maglione
bd881e062b Small fixes for recent commits. 2009-01-15 15:44:21 -05:00
Doug Kearns
5fe2741dfc Refactor editor.removeAllAbbreviations.
Add some rough source documentation for abbreviation related methods in
Editor.
2009-01-15 22:21:16 +11:00
Ted Pavlic
d29013a2fd Three small changes (copyright, template.js copyright, and tildetidy target)
a.) Cleaned up copyright language to match conventions.
(I used the memoir document class documentation as a reference, but
 these conventions are common throughout publishing)

   * The (c) symbol has no legal meaning. Only the word "Copyright" and
     an encircled lowercase c are appropriate. So the word "Copyright"
     was placed before each (c).

   * Each (C) was changed to (c).

   * Kris uses the correct symbols in copyright notices, but those
     symbols can be problematic in terminal-mode editors. Added the word
     "Copyright" as well.

   * Replaced colons/spaces after years with the word "by."

b.) Added a copyright notice to common/content/template.js. It was
    missing one entirely. Please correct if it doesn't need one or if the
    copyright isn't held by Martin.

c.) Also added a "tildetidy" target to Makefile common that includes a
    version of the find line from the existing "clean" target (however,
    this version uses "rm -fv" instead of "rm -f").
2009-01-12 09:14:54 -05:00
Ted Pavlic
147cdab5d2 Update copyrights for 2009. 2009-01-11 00:47:56 -05:00
Martin Stubenschrott
f09ad33e28 Fixed v exiting visual mode, thanks Xie&Tian 2009-01-06 14:00:27 +01:00
Doug Kearns
e91fbcd754 Add some source documentation for AutoCommands.
Also normalise the use of /* */ and // comments.
2009-01-02 00:56:58 +11:00
teramako
0653d64448 expand a path of editor option when open external editor 2009-01-01 22:01:39 +09:00
Doug Kearns
eeca611435 Add some more rough source documentation. 2009-01-01 22:01:56 +11:00
Doug Kearns
0f0d26d504 Normalise element related temporary variable names (elt -> elem). 2008-12-31 13:08:41 +11:00