1
0
mirror of https://github.com/gryf/pentadactyl-pm.git synced 2025-12-22 11:37:57 +01:00
Commit Graph

15 Commits

Author SHA1 Message Date
Kris Maglione
6a25312c7d Recfactoring:
* Standard module format. All modules are explicitly declared
   as modules, they're created via a constructor and
   instantiated automatically. They're dependency aware. They
   stringify properly.

 * Classes are declared the same way (rather like Structs
   already were). They also stringify properly. Plus, each
   instance has a rather nifty closure member that closes all
   of its methods around 'this', so you can pass them to map,
   forEach, setTimeout, etc. Modules are themselves classes,
   with a special metaclass, as it were.

 * Doug Crockford is dead, metaphorically speaking.
   Closure-based classes just don't fit into any of the common
   JavaScript frameworks, and they're inefficient and
   confusing. Now, all class and module members are accessed
   explicitly via 'this', which makes it very clear that
   they're class members and not (e.g.) local variables,
   without anything nasty like Hungarian notation.

 * Strictly one module per file. Classes that belong to a
   module live in the same file.

 * For the moment, there are quite a few utility functions
   sitting in base.c, because my class implementation used
   them, and I haven't had the time or inclination to sort them
   out. I plan to reconcile them with the current mess that is
   the util namespace.

 * Changed bracing style.
2009-11-08 20:54:31 -05:00
Kris Maglione
1ce498401e Add liberator.assert. 2009-11-03 02:36:48 -05:00
Martin Stubenschrott
3910c0604b Move all files to a MIT license 2009-10-03 00:32:29 +02:00
Kris Maglione
4b43c2b3e5 Fix /find error message on submit with 'incsearch' 2009-09-17 11:07:54 -04:00
Doug Kearns
2b7e4dcb67 Remove redundant semicolons. 2009-09-04 21:58:43 +10:00
Doug Kearns
a60f744b7a Fix #333 (Incremental search: /<CR> doesn't work; but n/N does). 2009-08-21 23:57:42 +10:00
Doug Kearns
519908eb2e Fix #285 (Find next doesn't highlight after refresh). 2009-08-10 06:29:11 +10:00
Doug Kearns
c062cf48df Move liberator.{register,trigger}Callback to CommandLine. 2009-07-11 00:43:16 +10:00
Doug Kearns
3f5dd13453 Fix typo in finder.openPrompt refactoring. 2009-06-28 17:22:16 +10:00
Doug Kearns
f3fd72b776 Refactor finder.openPrompt. 2009-06-28 16:03:24 +10:00
Doug Kearns
6d7b94daa6 Add missing semicolons. 2009-06-02 16:59:24 +10:00
Doug Kearns
26dabbfd0d Change multiline error message guard clauses to single line formatting.
Also apply similar formattng fixes to conditional blocks as per
standard.
2009-05-22 10:53:17 +10:00
Doug Kearns
cb0a352454 Fix an old call to snapshotItem in highlightObj.highlightDoc.
Spans are now stored in an array.
2009-05-22 10:52:59 +10:00
Doug Kearns
7fc37fe79c Remove some old/invalid FIXME comments. 2009-05-13 01:34:09 +10:00
Doug Kearns
cb0f542e94 Rename Search to Finder.
Search generally refers to web searches in this domain and mixing
"search" and "find" within the same module is very confusing.
2009-05-11 17:53:33 +10:00